Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/118255
Change subject: Make RankSelector tests reflect actual behavior
......................................................................
Make RankSelector tests reflect actual behavior
Change-Id: I5657136c2a9d6526fd38d9e2b84783547d5838ae
---
M
lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/55/118255/1
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
index 85d7232..a9e5585 100644
---
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
@@ -101,15 +101,8 @@
var rankSelector = createTestRankSelector();
assert.ok(
- !rankSelector.isDisabled(),
- 'Rank selector is enabled after instantiating.'
- );
-
- rankSelector.disable();
-
- assert.ok(
rankSelector.isDisabled(),
- 'Disabled rank selector.'
+ 'Rank selector is disabled after instantiating.'
);
rankSelector.enable();
@@ -118,6 +111,13 @@
!rankSelector.isDisabled(),
'Enabled rank selector.'
);
+
+ rankSelector.disable();
+
+ assert.ok(
+ rankSelector.isDisabled(),
+ 'Disabled rank selector.'
+ );
} );
QUnit.test( 'Multiple rank selectors', function ( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/118255
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5657136c2a9d6526fd38d9e2b84783547d5838ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <adrian.l...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
