jenkins-bot has submitted this change and it was merged.
Change subject: Make buttons more tab friendly. Focus progressive button.
......................................................................
Make buttons more tab friendly. Focus progressive button.
- Convert close button to <a> tag and handle the same as other buttons
Which puts it in the same tab order as the other buttons.
- Progressive button is focused when step shows
- tabbing from progressive button goes down the dom order
- shift tabbing from the progressive goes to the x button
Bug 66545
Change-Id: I1446c66544589262cb7dedb050452a8c138376d7
---
M modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js
M modules/mediawiki.libs.guiders/mediawiki.libs.guiders.less
2 files changed, 9 insertions(+), 5 deletions(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js
b/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js
index b686191..a1ef1a0 100644
--- a/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js
+++ b/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js
@@ -277,12 +277,14 @@
var xButtonContainer, xButton;
xButtonContainer = myGuider.elem.find('.guider_close');
- xButton = $('<div></div>', {
- 'class': 'x_button',
- role: 'button' });
+ xButton = $('<a>',
+ $.extend({'class': 'x_button'},
guiders._buttonAttributes)
+ );
xButtonContainer.append(xButton);
- xButton.click(function() {
- guiders.handleOnClose(myGuider, true, 'xButton');
+ xButton.on({
+ click: function() {
+ guiders.handleOnClose(myGuider, true,
'xButton');
+ }
});
};
@@ -950,6 +952,7 @@
}
$(myGuider.elem).trigger('guiders.show');
+ $(myGuider.elem).find('.mw-ui-progressive:first-child').focus();
// Create (preload) next guider if it hasn't been created
nextGuiderId = myGuider.next || null;
diff --git a/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.less
b/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.less
index 5f1abc5..bafd0a3 100755
--- a/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.less
+++ b/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.less
@@ -44,6 +44,7 @@
.x_button {
cursor: pointer;
+ display: block;
height: 13px;
width: 13px;
background-repeat: no-repeat;
--
To view, visit https://gerrit.wikimedia.org/r/140573
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1446c66544589262cb7dedb050452a8c138376d7
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/GuidedTour
Gerrit-Branch: master
Gerrit-Owner: Robmoen <rm...@wikimedia.org>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Phuedx <g...@samsmith.io>
Gerrit-Reviewer: Swalling <swall...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
