Brian Wolff has uploaded a new change for review. Change subject: Make the width/height in the SVG metadata box be in the SVG's units ......................................................................
Make the width/height in the SVG metadata box be in the SVG's units This was suggested by a user at commons. The width/height in px is really a MediaWiki thingy needed for rendering the image, from a metadata prespective its the original units (aka the image should be 10cm, etc) that is the information associated with the file. The dimensions in pixels is still specified in the long description of the image (the subtitle directly under the image). Note: After gerrit change Ic58efbf2 is merged, this will cause no width or height to be displayed for svg images with cached metadata, until they get purged. I think that's perfectly ok as the width is available elsewhere on the page. p.s. I added one semi-unrelated code comment in SVGMetadataExtractor. Change-Id: I312fbd1c935a0095644c3b63c4929632c6f6e387 --- M RELEASE-NOTES-1.20 M includes/media/SVG.php M includes/media/SVGMetadataExtractor.php 3 files changed, 24 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/63/20663/1 -- To view, visit https://gerrit.wikimedia.org/r/20663 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I312fbd1c935a0095644c3b63c4929632c6f6e387 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Brian Wolff <bawolff...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
