EBernhardson (WMF) has uploaded a new change for review. https://gerrit.wikimedia.org/r/64986
Change subject: Remove temporary backwards compatability hack for Echo ...................................................................... Remove temporary backwards compatability hack for Echo The patch with Change-ID of I5e8c89613f448c90efd1f487fe12edd68dc1d678 introduced a temporary hack for backwards compatability with Echo. This patch removes that hack and must be applied after deploying the updated Echo extension. Change-Id: I32ae0f9280b256a9bd5cc61127b6bcf89e325df8 --- M includes/Preferences.php 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/86/64986/1 diff --git a/includes/Preferences.php b/includes/Preferences.php index 367008e..a6d530f 100644 --- a/includes/Preferences.php +++ b/includes/Preferences.php @@ -1572,10 +1572,6 @@ if ( $field instanceof HTMLNestedFilterable ) { $info = $field->mParams; $prefix = isset( $info['prefix'] ) ? $info['prefix'] : $fieldname; - // TODO: temporary hack can be removed after echo deployment with 'prefix' => 'echo-subscriptions-' as param - if ( $field instance HTMLCheckMatrix && $prefix === 'echo-subscriptions' ) { - $prefix = "$prefix-"; - } foreach ( $field->filterDataForSubmit( $data[$fieldname] ) as $key => $value ) { $data["$prefix$key"] = $value; } -- To view, visit https://gerrit.wikimedia.org/r/64986 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I32ae0f9280b256a9bd5cc61127b6bcf89e325df8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: EBernhardson (WMF) <ebernhard...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits