[MediaWiki-commits] [Gerrit] Remove unused 'comment.svg' indicator image - change (VisualEditor/VisualEditor)

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/148980

Change subject: Remove unused 'comment.svg' indicator image
......................................................................

Remove unused 'comment.svg' indicator image

Follows-up ab2d4cb.

The image looks confusing (an orange rounded corner?
http://i.imgur.com/f8DV3EK.png) and isn't actually used anywhere.

CommentInspector and CommentInspectorTool both use an 'icon' image,
not an 'indicator' image named 'comment', which is provided by
OOjs UI (http://i.imgur.com/W3oGRuL.png).

Change-Id: Ie04a469c10ba178b0ed8fa77f7d088df68109e7c
---
D modules/ve/ui/styles/images/indicators/comment.svg
M modules/ve/ui/styles/ve.ui.Icons.css
2 files changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/80/148980/1

diff --git a/modules/ve/ui/styles/images/indicators/comment.svg 
b/modules/ve/ui/styles/images/indicators/comment.svg
deleted file mode 100644
index f1d6b10..0000000
--- a/modules/ve/ui/styles/images/indicators/comment.svg
+++ /dev/null
@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<svg xmlns="http://www.w3.org/2000/svg"; width="8" height="8" viewBox="0 0 8 8">
-    <g id="comment" opacity=".75">
-        <path fill="#ff5d00" d="M6 12c-3.314 0-6-2.686-6-6s2.686-6 6-6 6 2.686 
6 6-2.686 6-6 6zm-1-5h2v-5h-2zm0 3h2v-2h-2z"/>
-    </g>
-</svg>
diff --git a/modules/ve/ui/styles/ve.ui.Icons.css 
b/modules/ve/ui/styles/ve.ui.Icons.css
index 4b82153..d68ae50 100644
--- a/modules/ve/ui/styles/ve.ui.Icons.css
+++ b/modules/ve/ui/styles/ve.ui.Icons.css
@@ -279,8 +279,3 @@
 .ve-ui-icon-resize-ne-sw {
        background-image: url(images/resize-ne-sw.svg);
 }
-
-.oo-ui-indicator-comment {
-       /* @embed */
-       background-image: url(images/indicators/comment.svg);
-}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/148980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie04a469c10ba178b0ed8fa77f7d088df68109e7c
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits