Deskana has uploaded a new change for review. https://gerrit.wikimedia.org/r/300716
Change subject: Remove unused field from SavedPagesFragment class ...................................................................... Remove unused field from SavedPagesFragment class The app field in SavedPagesFragment is assigned and then never used. This patch removes the unused field for performance and code cleanliness reasons. Change-Id: I6b7477406c95753c5cd7351f2105cfc4fbb74301 --- M app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/16/300716/1 diff --git a/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java b/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java index f11651f..45bae83 100644 --- a/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java +++ b/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java @@ -59,8 +59,6 @@ private EditText entryFilter; private ImageView savedPagesEmptyImage; - private WikipediaApp app; - private ActionMode actionMode; private SavedPageSearchTextWatcher textWatcher = new SavedPageSearchTextWatcher(); private SavedPageItemClickListener itemClickListener = new SavedPageItemClickListener(); @@ -72,7 +70,6 @@ public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setRetainInstance(true); - app = WikipediaApp.getInstance(); adapter = new SavedPagesAdapter(getActivity(), null, true); } -- To view, visit https://gerrit.wikimedia.org/r/300716 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6b7477406c95753c5cd7351f2105cfc4fbb74301 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Deskana <dga...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits