Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174842
Change subject: Remove unused use clauses and fix typo in a class name
......................................................................
Remove unused use clauses and fix typo in a class name
Change-Id: I72a07642123864c6e54203372e520c9805b39bbd
---
M client/WikibaseClient.hooks.php
M client/includes/DataAccess/PropertyParserFunction/SnaksFinder.php
M client/includes/WikibaseClient.php
M client/includes/scribunto/WikibaseLuaEntityBindings.php
M client/tests/phpunit/includes/Changes/ChangeHandlerTest.php
M client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php
M client/tests/phpunit/includes/UpdateRepo/UpdateRepoOnDeleteTest.php
M client/tests/phpunit/includes/WikibaseClientTest.php
M client/tests/phpunit/includes/scribunto/WikibaseLuaEntityBindingsTest.php
M lib/tests/phpunit/TimeFormatterParserRoundtripTest.php
M lib/tests/phpunit/WikibaseDataTypeBuildersTest.php
M lib/tests/phpunit/serializers/EntitySerializerBaseTest.php
12 files changed, 11 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/42/174842/1
diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php
index 508d905..9858fbb 100644
--- a/client/WikibaseClient.hooks.php
+++ b/client/WikibaseClient.hooks.php
@@ -5,9 +5,11 @@
use Action;
use BaseTemplate;
use ChangesList;
+use Content;
use FormOptions;
use IContextSource;
use JobQueueGroup;
+use ManualLogEntry;
use Message;
use MovePageForm;
use MWException;
@@ -25,25 +27,23 @@
use UnexpectedValueException;
use User;
use Wikibase\Client\Changes\ChangeHandler;
-use WikiPage;
-use Content;
-use ManualLogEntry;
+use Wikibase\Client\DeletePageNoticeCreator;
use Wikibase\Client\Hooks\BaseTemplateAfterPortletHandler;
use Wikibase\Client\Hooks\BeforePageDisplayHandler;
use Wikibase\Client\Hooks\ChangesPageWikibaseFilterHandler;
use Wikibase\Client\Hooks\InfoActionHookHandler;
use Wikibase\Client\Hooks\SpecialWatchlistQueryHandler;
use Wikibase\Client\MovePageNotice;
-use Wikibase\Client\DeletePageNoticeCreator;
use Wikibase\Client\RecentChanges\ChangeLineFormatter;
use Wikibase\Client\RecentChanges\ExternalChangeFactory;
use Wikibase\Client\RecentChanges\RecentChangesFilterOptions;
use Wikibase\Client\RepoItemLinkGenerator;
-use Wikibase\Client\UpdateRepo\UpdateRepoOnMove;
use Wikibase\Client\UpdateRepo\UpdateRepoOnDelete;
+use Wikibase\Client\UpdateRepo\UpdateRepoOnMove;
use Wikibase\Client\WikibaseClient;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\SiteLink;
+use WikiPage;
/**
* File defining the hook handlers for the Wikibase Client extension.
diff --git a/client/includes/DataAccess/PropertyParserFunction/SnaksFinder.php
b/client/includes/DataAccess/PropertyParserFunction/SnaksFinder.php
index e4451d7..d85204b 100644
--- a/client/includes/DataAccess/PropertyParserFunction/SnaksFinder.php
+++ b/client/includes/DataAccess/PropertyParserFunction/SnaksFinder.php
@@ -8,7 +8,6 @@
use Wikibase\DataModel\Snak\Snak;
use Wikibase\DataModel\Statement\BestStatementsFinder;
use Wikibase\DataModel\Statement\Statement;
-use Wikibase\DataModel\Statement\StatementList;
use Wikibase\DataModel\StatementListProvider;
use Wikibase\Lib\Store\EntityLookup;
diff --git a/client/includes/WikibaseClient.php
b/client/includes/WikibaseClient.php
index a9b29a5..7c3ebd1 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -13,7 +13,6 @@
use Site;
use SiteSQLStore;
use SiteStore;
-use ValueFormatters\FormatterOptions;
use Wikibase\Client\Changes\AffectedPagesFinder;
use Wikibase\Client\Changes\ChangeHandler;
use Wikibase\Client\Changes\ChangeRunCoalescer;
diff --git a/client/includes/scribunto/WikibaseLuaEntityBindings.php
b/client/includes/scribunto/WikibaseLuaEntityBindings.php
index f1fdd77..f90ca80 100644
--- a/client/includes/scribunto/WikibaseLuaEntityBindings.php
+++ b/client/includes/scribunto/WikibaseLuaEntityBindings.php
@@ -7,14 +7,14 @@
use Wikibase\DataModel\Claim\Claims;
use Wikibase\DataModel\Entity\Entity;
use Wikibase\DataModel\Entity\EntityId;
+use Wikibase\DataModel\Entity\EntityIdParser;
use Wikibase\DataModel\Entity\EntityIdValue;
-use Wikibase\DataModel\StatementListProvider;
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Snak\Snak;
+use Wikibase\DataModel\StatementListProvider;
use Wikibase\Lib\SnakFormatter;
use Wikibase\Lib\Store\EntityLookup;
-use Wikibase\DataModel\Entity\EntityIdParser;
/**
* Actual implementations of the functions to access Wikibase through the
Scribunto extension
diff --git a/client/tests/phpunit/includes/Changes/ChangeHandlerTest.php
b/client/tests/phpunit/includes/Changes/ChangeHandlerTest.php
index 814d8b6..57b5d06 100644
--- a/client/tests/phpunit/includes/Changes/ChangeHandlerTest.php
+++ b/client/tests/phpunit/includes/Changes/ChangeHandlerTest.php
@@ -3,7 +3,6 @@
namespace Wikibase\Client\Tests\Changes;
use ArrayIterator;
-use Diff\Differ\MapDiffer;
use Site;
use Title;
use Wikibase\Change;
diff --git
a/client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php
b/client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php
index ff1a82d..b8dbc26 100644
--- a/client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php
+++ b/client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php
@@ -2,7 +2,6 @@
namespace Wikibase\Client\Tests\DataAccess;
-use DataValues\StringValue;
use Wikibase\DataAccess\PropertyIdResolver;
use Wikibase\DataModel\Entity\Property;
use Wikibase\DataModel\Entity\PropertyId;
diff --git
a/client/tests/phpunit/includes/UpdateRepo/UpdateRepoOnDeleteTest.php
b/client/tests/phpunit/includes/UpdateRepo/UpdateRepoOnDeleteTest.php
index ca4550d..b566eb5 100644
--- a/client/tests/phpunit/includes/UpdateRepo/UpdateRepoOnDeleteTest.php
+++ b/client/tests/phpunit/includes/UpdateRepo/UpdateRepoOnDeleteTest.php
@@ -4,8 +4,8 @@
use Title;
use User;
-use Wikibase\DataModel\Entity\ItemId;
use Wikibase\Client\UpdateRepo\UpdateRepoOnDelete;
+use Wikibase\DataModel\Entity\ItemId;
/**
* @covers Wikibase\Client\UpdateRepo\UpdateRepoOnDelete
diff --git a/client/tests/phpunit/includes/WikibaseClientTest.php
b/client/tests/phpunit/includes/WikibaseClientTest.php
index 27bb877..e6e439d 100644
--- a/client/tests/phpunit/includes/WikibaseClientTest.php
+++ b/client/tests/phpunit/includes/WikibaseClientTest.php
@@ -5,7 +5,6 @@
use Language;
use MediaWikiSite;
use SiteStore;
-use ValueFormatters\FormatterOptions;
use Wikibase\Client\WikibaseClient;
use Wikibase\DataModel\Entity\Item;
use Wikibase\SettingsArray;
diff --git
a/client/tests/phpunit/includes/scribunto/WikibaseLuaEntityBindingsTest.php
b/client/tests/phpunit/includes/scribunto/WikibaseLuaEntityBindingsTest.php
index f805c71..98ef472 100644
--- a/client/tests/phpunit/includes/scribunto/WikibaseLuaEntityBindingsTest.php
+++ b/client/tests/phpunit/includes/scribunto/WikibaseLuaEntityBindingsTest.php
@@ -8,6 +8,7 @@
use Wikibase\Client\Usage\HashUsageAccumulator;
use Wikibase\Client\Usage\UsageAccumulator;
use Wikibase\DataModel\Claim\Claim;
+use Wikibase\DataModel\Entity\BasicEntityIdParser;
use Wikibase\DataModel\Entity\Entity;
use Wikibase\DataModel\Entity\EntityIdValue;
use Wikibase\DataModel\Entity\Item;
@@ -17,7 +18,6 @@
use Wikibase\DataModel\Statement\Statement;
use Wikibase\Lib\SnakFormatter;
use Wikibase\Lib\Store\EntityLookup;
-use Wikibase\DataModel\Entity\BasicEntityIdParser;
use Wikibase\Test\MockRepository;
/**
diff --git a/lib/tests/phpunit/TimeFormatterParserRoundtripTest.php
b/lib/tests/phpunit/TimeFormatterParserRoundtripTest.php
index cf72e10..0b9e2fe 100644
--- a/lib/tests/phpunit/TimeFormatterParserRoundtripTest.php
+++ b/lib/tests/phpunit/TimeFormatterParserRoundtripTest.php
@@ -5,7 +5,6 @@
use DataValues\TimeValue;
use ValueFormatters\FormatterOptions;
use ValueFormatters\TimeFormatter;
-use ValueParsers\ParserOptions;
use Wikibase\Lib\MwTimeIsoFormatter;
use Wikibase\Lib\Parsers\TimeParser;
diff --git a/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php
b/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php
index 64b714c..3f2818a 100644
--- a/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php
+++ b/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php
@@ -166,8 +166,8 @@
array( 'quantity', QuantityValue::newFromDecimal(
'-11.234', '1', '-10', '-12' ), true, 'decimal strings' ),
//monolingual text
- array( 'monolingualtext', new MonoLingualTextValue(
'en', 'text' ), true, 'Simple value' ),
- array( 'monolingualtext', new MonoLingualTextValue(
'grrr', 'text' ), false, 'Not a valid language' ),
+ array( 'monolingualtext', new MonolingualTextValue(
'en', 'text' ), true, 'Simple value' ),
+ array( 'monolingualtext', new MonolingualTextValue(
'grrr', 'text' ), false, 'Not a valid language' ),
);
if ( defined( 'WB_EXPERIMENTAL_FEATURES' ) &&
WB_EXPERIMENTAL_FEATURES ) {
diff --git a/lib/tests/phpunit/serializers/EntitySerializerBaseTest.php
b/lib/tests/phpunit/serializers/EntitySerializerBaseTest.php
index 9b23122..f5c9e9b 100644
--- a/lib/tests/phpunit/serializers/EntitySerializerBaseTest.php
+++ b/lib/tests/phpunit/serializers/EntitySerializerBaseTest.php
@@ -2,7 +2,6 @@
namespace Wikibase\Test;
-use DataValues\StringValue;
use Wikibase\DataModel\Entity\Entity;
use Wikibase\Lib\Serializers\SerializationOptions;
--
To view, visit https://gerrit.wikimedia.org/r/174842
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72a07642123864c6e54203372e520c9805b39bbd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
