jenkins-bot has submitted this change and it was merged.

Change subject: SelectFileWidget: Mute the drag and drop design
......................................................................


SelectFileWidget: Mute the drag and drop design

Don't use very bright progressive colour as a fill, use item
highlight colour instead. In the MediaWiki theme, use a 1px
border for consistency.

Change-Id: Ifb62d3a70cd71923c074607ad73e7397575361c1
---
M src/themes/apex/widgets.less
M src/themes/mediawiki/widgets.less
2 files changed, 3 insertions(+), 13 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index a133a23..8c459fe 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -297,12 +297,7 @@
 
        &.oo-ui-selectFileWidget-dragdrop-ui &-handle:hover,
        &.oo-ui-selectFileWidget-dragdrop-ui.oo-ui-selectFileWidget-canDrop 
&-handle {
-                       background-color: @progressive;
-                       border-color: #fff;
-
-                       .oo-ui-labelElement-label {
-                               color: #fff;
-                       }
+               background-color: #eee;
        }
 }
 
diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index 350b4b1..58062b6 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -282,7 +282,7 @@
 
        &.oo-ui-selectFileWidget-dragdrop-ui &-handle {
                height: 3.5em;
-               border: 2px dashed @text;
+               border: 1px dashed #ccc;
                border-radius: 0em;
                padding: 0.5em 1em;
                background: #fff;
@@ -300,12 +300,7 @@
 
        &.oo-ui-selectFileWidget-dragdrop-ui &-handle:hover,
        &.oo-ui-selectFileWidget-dragdrop-ui.oo-ui-selectFileWidget-canDrop 
&-handle {
-                       background-color: @progressive-hover;
-                       border-color: #fff;
-
-                       .oo-ui-labelElement-label {
-                               color: #fff;
-                       }
+               background-color: #eee;
        }
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/233437
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb62d3a70cd71923c074607ad73e7397575361c1
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Bartosz DziewoƄski <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to