Mobrovac has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/213511

Change subject: Set $::ipaddress_eth0 as the default IP address
......................................................................

Set $::ipaddress_eth0 as the default IP address

All of the relevant IP addresses in Cassandra (listen_address,
rpc_address, seeds) need to point to a public network interface by
default. However, using $::ipaddress causes Puppet to pick the first
one, even if it is a private iface. This patch switches the default to
be $::ipaddress_eth0

Note: this change does not affect the actual configuration in
production, as there the first iface happens to be eth0.

Bug: T99564
Change-Id: I0eb118825bc98c2e4c9d0f673d3af522836ac21b
---
M manifests/init.pp
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet/cassandra 
refs/changes/11/213511/1

diff --git a/manifests/init.pp b/manifests/init.pp
index bb7baa3..0010b04 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -23,7 +23,7 @@
 #
 # [*seeds*]
 #   Array of seed IPs for this Cassandra cluster.
-#   Default: [$::ipaddress]
+#   Default: [$::ipaddress_eth0]
 #
 # [*num_tokens*]
 #   Number of tokens randomly assigned to this node on the ring.
@@ -88,7 +88,7 @@
 #   Default: 7000
 #
 # [*listen_address*]
-#   Cassandra listen IP address.  Default $::ipaddress
+#   Cassandra listen IP address.  Default $::ipaddress_eth0
 #
 # [*broadcast_address*]
 #   IP address to broadcast to other Cassandra nodes.  Default: undef (uses 
$listen _address)
@@ -103,7 +103,8 @@
 #   Whether to start the thrift rpc server.  Default: true
 #
 # [*rpc_address*]
-#   IP address to bind the Thrift RPC service and native transport server.  
Default: $::ipaddress
+#   IP address to bind the Thrift RPC service and native transport server.
+#   Default: $::ipaddress_eth0
 #
 # [*rpc_port*]
 #   Port for Thrift to listen for clients on.  Default: 9160
@@ -174,7 +175,7 @@
 #
 class cassandra(
     $cluster_name                     = 'Test Cluster',
-    $seeds                            = [$::ipaddress],
+    $seeds                            = [$::ipaddress_eth0],
     $num_tokens                       = 256,
     $authenticator                    = true,
     $authorizor                       = true,
@@ -188,12 +189,12 @@
     $concurrent_writes                = 32,
     $concurrent_counter_writes        = 32,
     $storage_port                     = 7000,
-    $listen_address                   = $::ipaddress,
+    $listen_address                   = $::ipaddress_eth0,
     $broadcast_address                = undef,
     $start_native_transport           = 'true',
     $native_transport_port            = 9042,
     $start_rpc                        = 'true',
-    $rpc_address                      = $::ipaddress,
+    $rpc_address                      = $::ipaddress_eth0,
     $rpc_port                         = 9160,
     $rpc_server_type                  = 'sync',
     $incremental_backups              = 'false',

-- 
To view, visit https://gerrit.wikimedia.org/r/213511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0eb118825bc98c2e4c9d0f673d3af522836ac21b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/cassandra
Gerrit-Branch: master
Gerrit-Owner: Mobrovac <mobro...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to