Daniel Friesen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/133042
Change subject: Specify an explicit text colour on some components that change
the background colour.
......................................................................
Specify an explicit text colour on some components that change the background
colour.
These components separate themselves from the default colouring of the content
area by specifying a dedicated – typically light grey – background colour.
However they leave text colour unspecified and as a result if the skin should be
white on black instead of black on white this results in these components
becoming
white on white or white on light grey and becoming unreadable.
Fix this by explicitly specifying a text colour to use where the background
colour is set.
Bug: 64732
Change-Id: I12584de40a18929b610d46dceaea73f06fdc6541
---
M resources/src/mediawiki.action/mediawiki.action.edit.styles.css
M resources/src/mediawiki/mediawiki.notification.css
M skins/common/shared.css
3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/42/133042/1
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.styles.css
b/resources/src/mediawiki.action/mediawiki.action.edit.styles.css
index 7148b96..ff6e067 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.styles.css
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.styles.css
@@ -10,6 +10,7 @@
.editOptions {
background-color: #F0F0F0;
+ color: #252525;
border: 1px solid silver;
border-top: none;
padding: 1em 1em 1.5em 1em;
diff --git a/resources/src/mediawiki/mediawiki.notification.css
b/resources/src/mediawiki/mediawiki.notification.css
index 0c8152e..15d547e 100644
--- a/resources/src/mediawiki/mediawiki.notification.css
+++ b/resources/src/mediawiki/mediawiki.notification.css
@@ -22,6 +22,7 @@
margin-bottom: 0.5em;
border: solid 1px #ddd;
background-color: #fcfcfc;
+ color: #252525;
/* Message hides on-click */
/* See also mediawiki.notification.js */
cursor: pointer;
diff --git a/skins/common/shared.css b/skins/common/shared.css
index a5612e2..640669b 100644
--- a/skins/common/shared.css
+++ b/skins/common/shared.css
@@ -458,6 +458,7 @@
#pagehistory li.selected {
background-color: #f9f9f9;
+ color: #252525;
border: 1px dashed #aaa;
}
--
To view, visit https://gerrit.wikimedia.org/r/133042
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12584de40a18929b610d46dceaea73f06fdc6541
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Friesen <dan...@nadir-seen-fire.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
