Addshore has submitted this change and it was merged.
Change subject: Track max and avg statements per entity
......................................................................
Track max and avg statements per entity
Bug: T119977
Change-Id: Ib8a9d03801c216ccb436a6e9cd52daa354cfbab8
---
M graphite/datamodel/statements_per_entity.php
1 file changed, 30 insertions(+), 2 deletions(-)
Approvals:
Addshore: Verified; Looks good to me, approved
diff --git a/graphite/datamodel/statements_per_entity.php
b/graphite/datamodel/statements_per_entity.php
index 51ad474..aee019c 100755
--- a/graphite/datamodel/statements_per_entity.php
+++ b/graphite/datamodel/statements_per_entity.php
@@ -21,7 +21,18 @@
$rows = $queryResult->fetchAll();
- $totals = array();
+ $totals = array(
+ 'item' => 0,
+ 'property' => 0,
+ );
+ $maxes = array(
+ 'item' => 0,
+ 'property' => 0,
+ );
+ $entitiesWithStatements = array(
+ 'item' => 0,
+ 'property' => 0,
+ );
foreach( $rows as $row ) {
if( $row['namespace'] == '0' ) {
$entityType = 'item';
@@ -31,12 +42,17 @@
throw new LogicException( 'Couldn\'t identify
namespace: ' . $row['namespace'] );
}
- @$totals[$entityType] += ( $row['statements'] *
$row['count'] );
+ $totals[$entityType] += ( $row['statements'] *
$row['count'] );
+ $entitiesWithStatements[$entityType] += $row['count'];
$this->sendMetric(
"daily.wikidata.datamodel.$entityType.statements.count." . $row['statements'],
$row['count']
);
+
+ if( $maxes[$entityType] < $row['statements'] ) {
+ $maxes[$entityType] = $row['statements'];
+ }
}
foreach( $totals as $entityType => $value ) {
@@ -44,7 +60,19 @@
"daily.wikidata.datamodel.$entityType.statements.total",
$value
);
+ $this->sendMetric(
+
"daily.wikidata.datamodel.$entityType.statements.avg",
+ $value / $entitiesWithStatements[$entityType]
+ );
}
+
+ foreach( $maxes as $entityType => $value ) {
+ $this->sendMetric(
+
"daily.wikidata.datamodel.$entityType.statements.max",
+ $value
+ );
+ }
+
}
private function sendMetric( $name, $value ) {
--
To view, visit https://gerrit.wikimedia.org/r/256424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8a9d03801c216ccb436a6e9cd52daa354cfbab8
Gerrit-PatchSet: 2
Gerrit-Project: analytics/limn-wikidata-data
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
