Divec has uploaded a new change for review.
https://gerrit.wikimedia.org/r/285335
Change subject: Update cursor holders in showModelSelection
......................................................................
Update cursor holders in showModelSelection
Bug: T131674
Change-Id: I388056285a9b19fb3356b153da7c717fa691cdb8
---
M src/ce/ve.ce.Surface.js
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/35/285335/1
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 128028b..655fdcd 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -3177,7 +3177,7 @@
* @return {boolean} Whether the selection actually changed
*/
ve.ce.Surface.prototype.showModelSelection = function () {
- var selection;
+ var selection, changed;
if ( this.deactivated ) {
// Defer until view has updated
@@ -3188,7 +3188,13 @@
selection = this.getSelection();
if ( selection.isNativeCursor() && !this.focusedBlockSlug ) {
- return this.showSelectionState( this.getSelectionState(
selection.getModel().getRange() ) );
+ changed = this.showSelectionState(
+ this.getSelectionState( selection.getModel().getRange()
)
+ );
+ if ( changed ) {
+ this.updateCursorHolders();
+ return true;
+ }
}
return false;
--
To view, visit https://gerrit.wikimedia.org/r/285335
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I388056285a9b19fb3356b153da7c717fa691cdb8
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <da...@troi.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
