jenkins-bot has submitted this change and it was merged.

Change subject: Use 'div' instead of 'section' and 'article'
......................................................................


Use 'div' instead of 'section' and 'article'

The user-agent stylesheet was making the size
of both the h1's and h2's 1.5em as it was inside
<article> and <section>

:-webkit-any(article,aside,nav,section)
h1 - 1.5em user agent stylesheet
~h1 - 2em~ user agent stylesheet

Change-Id: Ied1d03f63c132dc3904d05cd4e55f70aa3f80c3d
---
M docs/kss/styleguide-template/index.html
M docs/kss/styleguide-template/public/kss.less
2 files changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/docs/kss/styleguide-template/index.html 
b/docs/kss/styleguide-template/index.html
index b6036b2..38f0dd1 100644
--- a/docs/kss/styleguide-template/index.html
+++ b/docs/kss/styleguide-template/index.html
@@ -19,7 +19,7 @@
        </header>
 
        <div class="container">
-               <nav class="content">
+               <nav>
                        <ul>
                                <li><a href="index.html"><span>0.0</span> 
Overview</a></li>
                                {{#eachRoot}}
@@ -28,12 +28,12 @@
                        </ul>
                </nav>
 
-               <article>
+               <div class="content">
                        {{#if overview}}
                                {{html overview}}
                        {{else}}
                                {{#eachSection rootNumber}}
-                               <section>
+                               <div>
                                        {{#whenDepth 1}}
                                                <h1>{{ reference }}.0 {{ header 
}}</h1>
                                        {{else}}
@@ -60,10 +60,10 @@
                                                                {{html 
description}}
                                                        {{/if}}
                                        {{/ifAny}}
-                               </section>
+                               </div>
                                {{/eachSection}}
                        {{/if}}
-               </article>
+               </div>
        </div>
 </div></body>
 </html>
diff --git a/docs/kss/styleguide-template/public/kss.less 
b/docs/kss/styleguide-template/public/kss.less
index f5ddff1..a1d62a3 100644
--- a/docs/kss/styleguide-template/public/kss.less
+++ b/docs/kss/styleguide-template/public/kss.less
@@ -1,4 +1,3 @@
-
 .container {
        width: 100%;
 }
@@ -7,7 +6,7 @@
        display: none;
 }
 
-article {
+.content {
        .example {
                blockquote {
                        margin-top: 20px;
@@ -25,7 +24,8 @@
        font-family: "Nimbus Sans L", "Liberation Sans", "Helvetica Neue", 
"Helvetica", "Arial", sans-serif;
 }
 
-.content.kss-no-margin {
+.kss-no-margin {
+       // FIXME: Is this being used anywhere? Remove if not.
        margin: 0;
 }
 
@@ -89,7 +89,7 @@
        }
 }
 
-article {
+.content {
        -webkit-flex: 1;
        flex: 1;
 
@@ -154,7 +154,7 @@
                width: auto;
        }
 
-       article {
+       .content {
                margin-left: 30px;
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/150812
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied1d03f63c132dc3904d05cd4e55f70aa3f80c3d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: Waldir <wal...@email.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to