WMDE-leszek has uploaded a new change for review. https://gerrit.wikimedia.org/r/289398
Change subject: Use SVG icons for pointers instead of SVG magic ...................................................................... Use SVG icons for pointers instead of SVG magic Pointer shadow is left out here on purpose. It will be added after changing "new" pointer's position. Bug: T134994 Change-Id: Id80ed63cda9f015228a22bb1d8b9b742438fe27d --- M extension.json M modules/ext.RevisionSlider.css A resources/ext.RevisionSlider.pointers/pointer-new.svg A resources/ext.RevisionSlider.pointers/pointer-old.svg 4 files changed, 21 insertions(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider refs/changes/98/289398/1 diff --git a/extension.json b/extension.json index a0e643d..b4acf9d 100755 --- a/extension.json +++ b/extension.json @@ -31,7 +31,8 @@ "ext.RevisionSlider.Slider", "ext.RevisionSlider.Revision", "ext.RevisionSlider.RevisionList", - "ext.RevisionSlider.fetchRevisions" + "ext.RevisionSlider.fetchRevisions", + "ext.RevisionSlider.pointers" ], "messages": [ "revisionslider-loading-out-of-range", @@ -100,6 +101,15 @@ "scripts": [ "modules/ext.RevisionSlider.RevisionListView.js" ] + }, + "ext.RevisionSlider.pointers": { + "position": "top", + "class": "ResourceLoaderImageModule", + "selector": ".{name}-pointer", + "images": { + "oldid": "resources/ext.RevisionSlider.pointers/pointer-old.svg", + "newid": "resources/ext.RevisionSlider.pointers/pointer-new.svg" + } } }, "ResourceFileModulePaths": { diff --git a/modules/ext.RevisionSlider.css b/modules/ext.RevisionSlider.css index eeb0e3b..713ce2d 100755 --- a/modules/ext.RevisionSlider.css +++ b/modules/ext.RevisionSlider.css @@ -69,19 +69,11 @@ margin: auto; z-index: 10; } -.oldid-pointer { - border-color: transparent transparent #ffe49c transparent; -} -.newid-pointer { - border-color: transparent transparent #a3d3ff transparent; -} .pointer { position: absolute !important; z-index: 11; - width: 0; - height: 0; - border-style: solid; - border-width: 0 10px 10px 10px; + width: 20px; + height: 10px; } #revision-slider-darkness { diff --git a/resources/ext.RevisionSlider.pointers/pointer-new.svg b/resources/ext.RevisionSlider.pointers/pointer-new.svg new file mode 100644 index 0000000..9d3afc2 --- /dev/null +++ b/resources/ext.RevisionSlider.pointers/pointer-new.svg @@ -0,0 +1,4 @@ +<?xml version="1.0"?> +<svg width="20" height="10" viewPort="0 0 20 10" version="1.1" xmlns="http://www.w3.org/2000/svg"> + <polygon points="0,10 20,10 10,0" fill="#45a6ff" stroke="#065cad"/> +</svg> diff --git a/resources/ext.RevisionSlider.pointers/pointer-old.svg b/resources/ext.RevisionSlider.pointers/pointer-old.svg new file mode 100644 index 0000000..d44fe4d --- /dev/null +++ b/resources/ext.RevisionSlider.pointers/pointer-old.svg @@ -0,0 +1,4 @@ +<?xml version="1.0"?> +<svg width="20" height="10" viewPort="0 0 20 10" version="1.1" xmlns="http://www.w3.org/2000/svg"> + <polygon points="0,10 20,10 10,0" fill="#fdc44b" stroke="#dda000"/> +</svg> -- To view, visit https://gerrit.wikimedia.org/r/289398 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id80ed63cda9f015228a22bb1d8b9b742438fe27d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/RevisionSlider Gerrit-Branch: master Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits