Southparkfan has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/173068

Change subject: Use __DIR__ instead of dirname( __FILE__ ) in 
generateJsonI18n.php
......................................................................

Use __DIR__ instead of dirname( __FILE__ ) in generateJsonI18n.php

The Extension.i18n.php files of extension are at the moment using dirname( 
__FILE__ ) instead of __DIR__ (which was introduced in PHP 5.3), even while 
MediaWiki itself already uses __DIR__ if possible. The replacement should not 
cause issues, as running this maintenance script against an extension requires 
that extension to be PHP 5.3 compatible.

Change-Id: Ie26a23ce8a0c3409bd978f6af8d78a1aa73edac8
---
M maintenance/generateJsonI18n.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/68/173068/1

diff --git a/maintenance/generateJsonI18n.php b/maintenance/generateJsonI18n.php
index 22d9940..9497aa9 100644
--- a/maintenance/generateJsonI18n.php
+++ b/maintenance/generateJsonI18n.php
@@ -221,7 +221,7 @@
        function {{FUNC}}( $cache, $code, &$cachedData ) {
                $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
                foreach ( $codeSequence as $csCode ) {
-                       $fileName = dirname( __FILE__ ) . 
"/{{OUT}}/$csCode.json";
+                       $fileName = __DIR__ . "/{{OUT}}/$csCode.json";
                        if ( is_readable( $fileName ) ) {
                                $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
                                foreach ( array_keys( $data ) as $key ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/173068
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie26a23ce8a0c3409bd978f6af8d78a1aa73edac8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Southparkfan <southparkfan...@hotmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to