Eranroz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/244254
Change subject: Use local keyword for image
......................................................................
Use local keyword for image
Use local keywords for image format. This is especially important for RTL where
English keywords
cause bidirectional mix, but also relevant to all other LTR languages.
Bug: T53852
Change-Id: Id6768ddc0ce68bb37c3f84284582167a9412d11b
---
M lib/wts.LinkHandler.js
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/54/244254/1
diff --git a/lib/wts.LinkHandler.js b/lib/wts.LinkHandler.js
index e1c6632..fd3d426 100644
--- a/lib/wts.LinkHandler.js
+++ b/lib/wts.LinkHandler.js
@@ -902,8 +902,8 @@
type = null;
nopts.push({
ck: 'manualthumb',
- ak: this.getAttributeValue(outerElt, 'manualthumb',
mwAliases.img_manualthumb),
- v: manualthumb,
+ ak: 'aa'+this.getAttributeValue(outerElt,
'manualthumb', mwAliases.img_manualthumb),
+ v: manualthumb
});
}
@@ -1046,9 +1046,8 @@
(o.ck !== 'bogus' || o.ak === no.ak[0]);
});
if (idx < 0) {
- // New option, default to English localization for most
languages
- // TODO: use first alias (localized) instead for RTL
languages (T53852)
- no.ak = no.ak.last();
+ // use first alias (localized)
+ no.ak = no.ak[0];
changed = true;
return; /* new option */
}
--
To view, visit https://gerrit.wikimedia.org/r/244254
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6768ddc0ce68bb37c3f84284582167a9412d11b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Eranroz <eranro...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
