Cscott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60850
Change subject: WIP: questions about hrefRE.
......................................................................
WIP: questions about hrefRE.
Change-Id: Ic2888b25431affc8f69fdb696b71aeabd653a90c
---
M js/lib/ext.core.Sanitizer.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/50/60850/1
diff --git a/js/lib/ext.core.Sanitizer.js b/js/lib/ext.core.Sanitizer.js
index 98c7827..ed2c3b9 100644
--- a/js/lib/ext.core.Sanitizer.js
+++ b/js/lib/ext.core.Sanitizer.js
@@ -614,6 +614,7 @@
proto = bits[1];
host = bits[2];
path = bits[3];
+ // XXX this.hrefRE is used here (but never defined?)
if ( ! proto.match(this.hrefRE)) {
// invalid proto, disallow URL
return null;
@@ -884,6 +885,7 @@
var html5Mode = this.constants.globalConfig.html5Mode;
var xmlnsRE = this.constants.XMLNS_ATTRIBUTE_RE;
var evilUriRE = this.constants.EVIL_URI_RE;
+// XXX should be this.hrefRE? It is unused.
var hrefRE = this.constants.validProtocolsRE;
var wlist = this.getAttrWhiteList(tag);
--
To view, visit https://gerrit.wikimedia.org/r/60850
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2888b25431affc8f69fdb696b71aeabd653a90c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <wikime...@cscott.net>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
