Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/118288
Change subject: WIP Moved "page has no ResourceLoader errors" to
mediawiki_selenium Ruby gem
......................................................................
WIP Moved "page has no ResourceLoader errors" to mediawiki_selenium Ruby gem
Change-Id: I17587f9916168812836524097e8728b6d7be8fc2
---
M tests/browser/features/step_definitions/create_account_steps.rb
1 file changed, 0 insertions(+), 35 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests
refs/changes/88/118288/1
diff --git a/tests/browser/features/step_definitions/create_account_steps.rb
b/tests/browser/features/step_definitions/create_account_steps.rb
index 779f69c..7fa2984 100644
--- a/tests/browser/features/step_definitions/create_account_steps.rb
+++ b/tests/browser/features/step_definitions/create_account_steps.rb
@@ -16,38 +16,3 @@
Then(/^form has Create account button$/) do
on(CreateAccountPage).create_account_element.should exist
end
-
-Then(/^page has no ResourceLoader errors$/) do
- @browser.execute_script("
-return (function() {
- // Returns a string listing problem modules,
- // or empty string if all OK (or not a MediaWiki page).
- // MediaWiki registers many JS modules that are not loaded on average
pages.
- var i, len, state,
- modules = mw.loader.getModuleNames(),
- error = [],
- missing = [],
- ret = '';
- if ( ( typeof mediaWiki === 'undefined' ) || !mediaWiki.loader ) {
- return ret;
- }
-
- for ( i = 0, len = modules.length; i < len; i++ ) {
- state = mw.loader.getState( modules[i] );
- if ( state === 'error' ) {
- error.push( modules[i] );
- }
- if ( state === 'missing' ) {
- missing.push( modules[i] );
- }
- }
- if ( error.length ) {
- ret += 'Error modules: ' + error.join( '; ') + '.';
- }
- if ( missing.length ) {
- ret += 'Missing modules: ' + missing.join( '; ') + '.';
- }
- return ret;
-}) ();
-").should == ""
-end
--
To view, visit https://gerrit.wikimedia.org/r/118288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17587f9916168812836524097e8728b6d7be8fc2
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
