Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221279
Change subject: WikidataPageBanner getWPBFunctionsInstace() added
......................................................................
WikidataPageBanner getWPBFunctionsInstace() added
This adds a static method to get a singleton of WikidataPageBannerFunctions
class. This would allow easy mocking of helper functions when static hooks need
to be tested. To mock, simply an overriding of the above method to return a mock
object with desired characteristics would be needed. This method is required
before moving non-hook functions from WikidataPageBanner to
WikidataPageBannerFunctions as static methods.
Change-Id: Ide40b5dcc4737117d0376df009ebeff191a294f7
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 16 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/79/221279/1
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index 27b3c6c..1275e4a 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -1,5 +1,10 @@
<?php
class WikidataPageBanner {
+ /**
+ * Singleton instance for helper class functions
+ * @var WikidataPageBannerFunctions
+ */
+ static $wpbFunctionsObj;
/**
* WikidataPageBanner::addDefaultBanner
@@ -306,4 +311,15 @@
}
return true;
}
+
+ /**
+ * Getter method to obtain an instance of WikidataPageBannerFunctions
+ * @return object WikidataPageBannerFunctions
+ */
+ public static function getWPBFunctionsInstance() {
+ if ( !isset( self::$wpbFunctionsObj ) ) {
+ self::$wpbFunctionsObj = new
WikidataPageBannerFunctions();
+ }
+ return self::$wpbFunctionsObj;
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/221279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide40b5dcc4737117d0376df009ebeff191a294f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
