jenkins-bot has submitted this change and it was merged. Change subject: Workaround of bug 72960, disabling WikiEditor dialog in Page namespace ......................................................................
Workaround of bug 72960, disabling WikiEditor dialog in Page namespace Workaround of issue when dialog class of WikiEditor isn't being loaded, affecting both WikiEditor functinality and tools/user scripts depending on that class. Some more long term solution would be to fix this in WikiEditor, by treating CONTENT_MODEL_PROOFREAD_PAGE same way as CONTENT_MODEL_WIKITEXT Bug: 72960 Bug: T72960 Change-Id: I6830b97519ed6027c198552eeaed86b82eb9ea30 --- M modules/page/ext.proofreadpage.page.edit.js 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Tpt: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/page/ext.proofreadpage.page.edit.js b/modules/page/ext.proofreadpage.page.edit.js index da1e709..5bce78a 100644 --- a/modules/page/ext.proofreadpage.page.edit.js +++ b/modules/page/ext.proofreadpage.page.edit.js @@ -224,6 +224,12 @@ $editForm.find( '.editOptions' ).before( $editForm.find( '.wikiEditor-ui' ) ); $editForm.find( '.wikiEditor-ui-text' ).append( $editForm.find( '.prp-page-container' ) ); } ); + + // load the "dialogs" module of WikiEditor if enabled , bug: 72960 + if( mw.user.options.get( 'usebetatoolbar-cgd' ) ) { + mw.loader.load('ext.wikiEditor.dialogs'); + } + // TODO: other modules of WikiEditor may miss, see bug 72960. } /** -- To view, visit https://gerrit.wikimedia.org/r/174936 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6830b97519ed6027c198552eeaed86b82eb9ea30 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: master Gerrit-Owner: Xelgen <xelgen...@gmail.com> Gerrit-Reviewer: Tpt <thomaspe...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits