Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314419
Change subject: Don't toggle the GPS when requesting location
......................................................................
Don't toggle the GPS when requesting location
The Mapbox SDK will quickly toggle location services if it was already
enabled and requested. This may be observed in the SDK sources and by
watching the location services system icon. This patch checks the enable
state first and enables location services only if required.
Change-Id: I7ebb9c38efd21c60b49385151ece8546016ddb49
---
M app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/19/314419/1
diff --git a/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
b/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
index 232dac9..888bd6d 100644
--- a/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
+++ b/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
@@ -425,7 +425,10 @@
}
private void updateLocationEnabled(@NonNull MapboxMap map) {
- map.setMyLocationEnabled(getUserVisibleHint());
+ // the mapbox sdk will actually quickly toggle the gps if it was
already enabled
+ if (!map.isMyLocationEnabled()) {
+ map.setMyLocationEnabled(getUserVisibleHint());
+ }
}
@SuppressLint("CommitPrefEdits")
--
To view, visit https://gerrit.wikimedia.org/r/314419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ebb9c38efd21c60b49385151ece8546016ddb49
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
