Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/201577
Change subject: ignore mobileprovision and fix early return
......................................................................
ignore mobileprovision and fix early return
Change-Id: I032d8a327c4f023611b0a83708bd0fc1e5cdf70a
---
M .gitignore
M fastlane/Appfile
M fastlane/Fastfile
3 files changed, 29 insertions(+), 27 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/77/201577/1
diff --git a/.gitignore b/.gitignore
index 8ecf4da..8e079ca 100644
--- a/.gitignore
+++ b/.gitignore
@@ -22,6 +22,7 @@
# Fastlane
fastlane/report.xml
fastlane/Error*.png
+*.mobileprovision
# Ignore baselines, which we'll eventually maintain in CI to prevent false
negatives due to dev machine discrepancies
xcbaselines/
diff --git a/fastlane/Appfile b/fastlane/Appfile
index ae8ac0d..17c8caa 100644
--- a/fastlane/Appfile
+++ b/fastlane/Appfile
@@ -7,7 +7,7 @@
apple_id "cfl...@wikimedia.org"
# Set the app identifier for each build (used to look up the app in itunes
connect)
-app_identifier "org.wikimedia.wikipedia.tfalpha"
+#app_identifier "org.wikimedia.wikipedia.tfalpha"
# for_lane :alpha do
# app_identifier "org.wikimedia.wikipedia.tfbeta"
diff --git a/fastlane/Fastfile b/fastlane/Fastfile
index 4aca246..f4304e4 100644
--- a/fastlane/Fastfile
+++ b/fastlane/Fastfile
@@ -16,14 +16,14 @@
xcbuild({
scheme: 'Wikipedia',
- analyze: true
+ analyze: nil
})
xctest({
scheme: 'Wikipedia',
destination: "platform=iOS Simulator,name=iPhone 5s,OS=8.2",
report_formats: [ "html", "junit" ],
- clean: true
+ clean: nil
})
end
@@ -57,22 +57,22 @@
# Create and sign the IPA (and DSYM)
ipa({
scheme: 'Wikipedia Alpha',
- clean: true,
+ clean: nil,
archive: nil
})
- return if ENV['NO_DEPLOY']
+ unless ENV['NO_DEPLOY']
+ # Upload the DSYM to Hockey
+ hockey({
+ api_token: 'c881c19fd8d0401682c4640b7948ef5e',
+ notes: "Changelog",
+ notify: 0,
+ status: 1, #Means do not make available for download
+ })
- # Upload the DSYM to Hockey
- hockey({
- api_token: 'c881c19fd8d0401682c4640b7948ef5e',
- notes: "Changelog",
- notify: 0,
- status: 1, #Means do not make available for download
- })
-
- # Upload the IPA and DSYM to iTunes Connect
- deliver :testflight, :beta, :skip_deploy, :force
+ # Upload the IPA and DSYM to iTunes Connect
+ deliver :testflight, :beta, :skip_deploy, :force
+ end
end
lane :beta do
@@ -105,24 +105,25 @@
archive: nil
})
- return if ENV['NO_DEPLOY']
+ unless ENV['NO_DEPLOY']
+ # Upload the DSYM to Hockey
+ hockey({
+ api_token: 'c881c19fd8d0401682c4640b7948ef5e',
+ notes: "Changelog",
+ notify: 0,
+ status: 1,
+ })
- # Upload the DSYM to Hockey
- hockey({
- api_token: 'c881c19fd8d0401682c4640b7948ef5e',
- notes: "Changelog",
- notify: 0,
- status: 1,
- })
-
- deliver :testflight, :beta, :force
+ deliver :testflight, :beta, :force
+ end
end
lane :appstore do
snapshot
frameit
- return if ENV['NO_DEPLOY']
- deliver :skip_deploy, :force
+ unless ENV['NO_DEPLOY']
+ deliver :skip_deploy, :force
+ end
end
after_all do |lane|
--
To view, visit https://gerrit.wikimedia.org/r/201577
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I032d8a327c4f023611b0a83708bd0fc1e5cdf70a
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Bgerstle <bgers...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
