Tim Landscheidt has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331227 )
Change subject: WIP: Don't ignore fchdir()'s errors
......................................................................
WIP: Don't ignore fchdir()'s errors
Change-Id: Ibe4b9f7a890a2a9f34c5e0baa7d9db10591c077b
---
M src/take.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/toollabs
refs/changes/27/331227/1
diff --git a/src/take.cc b/src/take.cc
index 45ba55e..380fd38 100755
--- a/src/take.cc
+++ b/src/take.cc
@@ -152,7 +152,8 @@
if(d->d_name[1]=='.' && d->d_name[2]==0)
continue;
}
- fchdir(file);
+ if (fchdir(file))
+ return error(path, d->d_name);
cwdchanged = true;
ok &= takeover(d->d_name, true);
}
@@ -221,7 +222,8 @@
bool ok = true;
for(int arg=optind; arg<argc; arg++) {
if (cwdchanged)
- fchdir(cwd);
+ if (fchdir(cwd))
+ return error(argv[arg]);
ok &= takeover(argv[arg], false);
}
close(cwd);
--
To view, visit https://gerrit.wikimedia.org/r/331227
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe4b9f7a890a2a9f34c5e0baa7d9db10591c077b
Gerrit-PatchSet: 1
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
