Dzahn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/122335
Change subject: lint labsproxy.pp
......................................................................
lint labsproxy.pp
4 x "unquoted file mode"
38 x "tab character found"
12 x "double quoted string containing no variables"
18 x "=> on line isn't properly aligned"
Change-Id: Id2a3bcdd75050c4e5a74302b27e17bb4cec5fe5b
---
M manifests/role/labsproxy.pp
1 file changed, 42 insertions(+), 42 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/35/122335/1
diff --git a/manifests/role/labsproxy.pp b/manifests/role/labsproxy.pp
index 6042eb5..0cbdfe7 100644
--- a/manifests/role/labsproxy.pp
+++ b/manifests/role/labsproxy.pp
@@ -4,27 +4,27 @@
# be directed to foo.pmtpa.wmflabs.
class role::pmtpa-proxy {
- $proxy_hostname = "pmtpa-proxy"
- $proxy_internal_domain = "pmtpa.wmflabs"
+ $proxy_hostname = 'pmtpa-proxy'
+ $proxy_internal_domain = 'pmtpa.wmflabs'
- nginx::site { 'pmtpa-labs-proxy':
- content => template('nginx/sites/labs-proxy.erb'),
- }
+ nginx::site { 'pmtpa-labs-proxy':
+ content => template('nginx/sites/labs-proxy.erb'),
+ }
- file {
- "/var/www":
- ensure => directory,
- owner => root,
- group => root,
- mode => 0555;
- "/var/www/robots.txt":
- ensure => present,
- require => File["/var/www"],
- mode => 0444,
- owner => root,
- group => root,
- source => "puppet:///files/misc/robots-txt-disallow";
- }
+ file {
+ '/var/www':
+ ensure => 'directory',
+ owner => 'root',
+ group => 'root',
+ mode => '0555';
+ '/var/www/robots.txt':
+ ensure => 'present',
+ require => File['/var/www'],
+ mode => '0444',
+ owner => 'root',
+ group => 'root',
+ source => 'puppet:///files/misc/robots-txt-disallow';
+ }
}
# Install an http proxy for eqiad labs instances.
@@ -33,27 +33,27 @@
# be directed to foo.eqiad.wmflabs.
class role::eqiad-proxy {
- $proxy_hostname = "eqiad-proxy"
- $proxy_internal_domain = "eqiad.wmflabs"
+ $proxy_hostname = 'eqiad-proxy'
+ $proxy_internal_domain = 'eqiad.wmflabs'
- nginx::site { 'eqiad-labs-proxy':
- content => template('nginx/sites/labs-proxy.erb'),
- }
+ nginx::site { 'eqiad-labs-proxy':
+ content => template('nginx/sites/labs-proxy.erb'),
+ }
- file {
- "/var/www":
- ensure => directory,
- owner => root,
- group => root,
- mode => 0555;
- "/var/www/robots.txt":
- ensure => present,
- require => File["/var/www"],
- mode => 0444,
- owner => root,
- group => root,
- source => "puppet:///files/misc/robots-txt-disallow";
- }
+ file {
+ '/var/www':
+ ensure => 'directory',
+ owner => 'root',
+ group => 'root',
+ mode => '0555';
+ '/var/www/robots.txt':
+ ensure => 'present',
+ require => File['/var/www'],
+ mode => '0444',
+ owner => 'root',
+ group => 'root',
+ source => 'puppet:///files/misc/robots-txt-disallow';
+ }
}
# A dynamic HTTP routing proxy, based on nginx+lua+redis
@@ -63,8 +63,8 @@
}
class { '::dynamicproxy':
ssl_certificate_name => 'star.wmflabs.org',
- set_xff => true,
- resolver => '10.4.0.1'
+ set_xff => true,
+ resolver => '10.4.0.1'
}
include dynamicproxy::api
}
@@ -76,8 +76,8 @@
}
class { '::dynamicproxy':
ssl_certificate_name => 'star.wmflabs.org',
- set_xff => true,
- resolver => '10.68.16.1'
+ set_xff => true,
+ resolver => '10.68.16.1'
}
include dynamicproxy::api
}
--
To view, visit https://gerrit.wikimedia.org/r/122335
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2a3bcdd75050c4e5a74302b27e17bb4cec5fe5b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
