jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/402112 )
Change subject: [BREAKING CHANGE] Rename TitleWidget#getTitle to
TitleWidget#getMWTitle
......................................................................
[BREAKING CHANGE] Rename TitleWidget#getTitle to TitleWidget#getMWTitle
Rename TitleWidget#getTitle so it won't clash with TitledElement#getTitle
Bug: T184181
Change-Id: I97ff46d8ca60f260af2a0b12e6c053aa91c777d1
---
M resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js
M resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Mooeypoo: Looks good to me, approved
diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js
b/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js
index a78ad82..98d07f3 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js
@@ -131,7 +131,7 @@
value =
mw.widgets.TitleInputWidget.parent.prototype.cleanUpValue.call( this, value );
return $.trimByteLength( this.value, value, this.maxLength,
function ( value ) {
- var title = widget.getTitle( value );
+ var title = widget.getMWTitle( value );
return title ? title.getMain() : value;
} ).newVal;
};
diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
index 5670ce4..0c6385b 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
@@ -355,7 +355,7 @@
* @param {string} [value] Value to get a title for
* @return {mw.Title|null} Title object, or null if value is invalid
*/
- mw.widgets.TitleWidget.prototype.getTitle = function ( value ) {
+ mw.widgets.TitleWidget.prototype.getMWTitle = function ( value ) {
var title = value !== undefined ? value : this.getQueryValue(),
// mw.Title doesn't handle null well
titleObj = mw.Title.newFromText( title, this.namespace
!== null ? this.namespace : undefined );
@@ -369,7 +369,7 @@
* @return {boolean} The query is valid
*/
mw.widgets.TitleWidget.prototype.isQueryValid = function () {
- return this.validateTitle ? !!this.getTitle() : true;
+ return this.validateTitle ? !!this.getMWTitle() : true;
};
}( jQuery, mediaWiki ) );
--
To view, visit https://gerrit.wikimedia.org/r/402112
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97ff46d8ca60f260af2a0b12e6c053aa91c777d1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Sbisson <sbis...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
