Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/336697 )

Change subject: Log a debug notice when headers were sent before now
......................................................................

Log a debug notice when headers were sent before now

Change-Id: Id01f4712e3dd297594e9ed2389ad411be5f553e7
---
M includes/WebResponse.php
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/97/336697/1

diff --git a/includes/WebResponse.php b/includes/WebResponse.php
index 339b2e3..8a28c71 100644
--- a/includes/WebResponse.php
+++ b/includes/WebResponse.php
@@ -39,6 +39,12 @@
         * @param null|int $http_response_code Forces the HTTP response code to 
the specified value.
         */
        public function header( $string, $replace = true, $http_response_code = 
null ) {
+               static $senders = [];
+
+               $senders[] = wfGetCaller();
+               if ( headers_sent() ) {
+                       MWDebug::warning( 'Headers already sent by:' . implode( 
',', $senders ), 2 );
+               }
                if ( $http_response_code ) {
                        header( $string, $replace, $http_response_code );
                } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/336697
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id01f4712e3dd297594e9ed2389ad411be5f553e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to