Mooeypoo has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/353484 )
Change subject: RCFilters: Actually read/write highlight parameter
......................................................................
RCFilters: Actually read/write highlight parameter
The highlight parameter enables/disables the highlight view. It was
not properly updated to the URL, and a separate typo made it not update
the model correctly.
Bug: T165107
Change-Id: Ie711d4d08fb3eeffca50c2953016e02e2620f898
---
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/84/353484/1
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index 1dd0f83..b73eef7 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -477,7 +477,7 @@
);
// Update highlight state
- this.filtersModel.toggleHighlight( !!parameters.highlights );
+ this.filtersModel.toggleHighlight( !!parameters.highlight );
this.filtersModel.getItems().forEach( function ( filterItem ) {
var color = parameters[ filterItem.getName() + '_color'
];
if ( color ) {
@@ -570,6 +570,7 @@
uri.extend( this.filtersModel.getParametersFromFilters() );
// highlight params
+ uri.query.highlight = this.filtersModel.isHighlightEnabled();
Object.keys( highlightParams ).forEach( function ( paramName ) {
if ( highlightParams[ paramName ] ) {
uri.query[ paramName ] = highlightParams[
paramName ];
--
To view, visit https://gerrit.wikimedia.org/r/353484
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie711d4d08fb3eeffca50c2953016e02e2620f898
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
