Sbisson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375417 )
Change subject: RCFilters: make is isStructuredFilterUiEnabled public ...................................................................... RCFilters: make is isStructuredFilterUiEnabled public ... so it can be used by ORES to know if it's enabled on a specific page without duplicating the checks of global variables, user preferences, and request parameters. Bug: T174725 Change-Id: I1cb402559edb242b40a77f509480560f0636264d --- M includes/specialpage/ChangesListSpecialPage.php M includes/specials/SpecialWatchlist.php 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/17/375417/1 diff --git a/includes/specialpage/ChangesListSpecialPage.php b/includes/specialpage/ChangesListSpecialPage.php index acd5d14..5f54404 100644 --- a/includes/specialpage/ChangesListSpecialPage.php +++ b/includes/specialpage/ChangesListSpecialPage.php @@ -1536,7 +1536,7 @@ * * @return bool */ - protected function isStructuredFilterUiEnabled() { + public function isStructuredFilterUiEnabled() { return $this->getUser()->getOption( 'rcenhancedfilters' ); } diff --git a/includes/specials/SpecialWatchlist.php b/includes/specials/SpecialWatchlist.php index ba3cb87..7049744 100644 --- a/includes/specials/SpecialWatchlist.php +++ b/includes/specials/SpecialWatchlist.php @@ -111,7 +111,7 @@ } } - protected function isStructuredFilterUiEnabled() { + public function isStructuredFilterUiEnabled() { return parent::isStructuredFilterUiEnabled() && ( $this->getConfig()->get( 'StructuredChangeFiltersOnWatchlist' ) || $this->getRequest()->getBool( 'rcfilters' ) ); -- To view, visit https://gerrit.wikimedia.org/r/375417 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1cb402559edb242b40a77f509480560f0636264d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Sbisson <sbis...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits