Awight has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/341722 )

Change subject: [WIP] Remove irrelevant test?
......................................................................

[WIP] Remove irrelevant test?

However, this test is failing on I4f1ebc984419a62401b820d7778ce4e46c90733a so
I'm concerned that nothing else is covering the same conditions.

Change-Id: I9d9bbbb48b2ed063bd142fa9423a94fe0d7afe04
---
M tests/phpunit/Adapter/GlobalCollect/GlobalCollectOrphanAdapterTest.php
1 file changed, 0 insertions(+), 28 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/22/341722/1

diff --git 
a/tests/phpunit/Adapter/GlobalCollect/GlobalCollectOrphanAdapterTest.php 
b/tests/phpunit/Adapter/GlobalCollect/GlobalCollectOrphanAdapterTest.php
index 6682a87..27c7c4e 100644
--- a/tests/phpunit/Adapter/GlobalCollect/GlobalCollectOrphanAdapterTest.php
+++ b/tests/phpunit/Adapter/GlobalCollect/GlobalCollectOrphanAdapterTest.php
@@ -114,34 +114,6 @@
                $this->verifyNoLogErrors();
        }
 
-       public function testGCFormLoad() {
-               $init = $this->getDonorTestData( 'US' );
-               unset( $init['order_id'] );
-               $init['payment_method'] = 'cc';
-               $init['payment_submethod'] = 'visa';
-               $init['ffname'] = 'cc-vmad';
-
-               $assertNodes = array (
-                       'submethod-mc' => array (
-                               'nodename' => 'input'
-                       ),
-                       'selected-amount' => array (
-                               'nodename' => 'span',
-                               'innerhtmlmatches' => '/^\s*' .
-                                       str_replace( '$', '\$',
-                                               Amount::format( 1.55, 'USD', 
$init['language'] . '_' . $init['country'] )
-                                       ).
-                                       '\s*$/',
-                       ),
-                       'state' => array (
-                               'nodename' => 'select',
-                               'selected' => 'CA',
-                       ),
-               );
-
-               $this->verifyFormOutput( 'GlobalCollectGateway', $init, 
$assertNodes, true );
-       }
-
        /**
         * Tests to make sure that certain error codes returned from GC will
         * trigger order cancellation, even if retryable errors also exist.

-- 
To view, visit https://gerrit.wikimedia.org/r/341722
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d9bbbb48b2ed063bd142fa9423a94fe0d7afe04
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to