Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311050
Change subject: Verify bundledNotifications data is an array before running
.map()
......................................................................
Verify bundledNotifications data is an array before running .map()
Bug: T145825
Change-Id: Ibdf17c58fe88e3e2547dde62cd4d3d06e089cbc8
---
M modules/controller/mw.echo.Controller.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/50/311050/1
diff --git a/modules/controller/mw.echo.Controller.js
b/modules/controller/mw.echo.Controller.js
index 59cb771..69e93bb 100644
--- a/modules/controller/mw.echo.Controller.js
+++ b/modules/controller/mw.echo.Controller.js
@@ -315,7 +315,7 @@
notifData.sources[ source ]
);
}
- } else if (
newNotifData.bundledNotifications ) {
+ } else if ( Array.isArray(
newNotifData.bundledNotifications ) ) {
// local bundle
newNotifData.modelName
= 'bundle_' + notifData.id;
itemModel = new
mw.echo.dm.BundleNotificationItem(
--
To view, visit https://gerrit.wikimedia.org/r/311050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdf17c58fe88e3e2547dde62cd4d3d06e089cbc8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
