jenkins-bot has submitted this change and it was merged. Change subject: Disable newcap in function where VisualEditorSupportCheck is used ......................................................................
Disable newcap in function where VisualEditorSupportCheck is used This is removed in a later version of jshint anyway (https://github.com/jshint/jshint/commit/39f93cc16e16aa95bf29918a9329e4ea6570f49b) but on the current version is causing CI issues (https://gerrit.wikimedia.org/r/#/c/318793). This is not compliant with our coding style, though, so at some point either we will need an exception for jscs (when it is enforced there), or to rename it. Change-Id: I5a725aa27bf7f5b87d2d67dbe1e3aab6493be23c --- M modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js b/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js index 6f88ea5..ba920e4 100644 --- a/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js +++ b/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js @@ -194,6 +194,8 @@ // Static methods mw.flow.editors.visualeditor.static.isSupported = function () { + /* jshint newcap: false */ + var isMobileTarget = ( mw.config.get( 'skin' ) === 'minerva' ); return !!( -- To view, visit https://gerrit.wikimedia.org/r/319333 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a725aa27bf7f5b87d2d67dbe1e3aab6493be23c Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Catrope <r...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
