jenkins-bot has submitted this change and it was merged. Change subject: eslint: Re-enable wrap-iife and partially enable dot-notation ......................................................................
eslint: Re-enable wrap-iife and partially enable dot-notation Also removed upstreamed spaced-comment rule. Change-Id: Ide83abeedfea27c1f4574af0069d5a9fdb81de84 --- M .eslintrc.json M modules/ve-math/tools/makeSvgsAndCss.js 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/.eslintrc.json b/.eslintrc.json index 955cabc..158c7b1 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -12,8 +12,6 @@ "OO": false }, "rules": { - "dot-notation": 0, - "wrap-iife": 0, - "spaced-comment": ["error", "always", { "exceptions": ["*", "!"] }] + "dot-notation": [ "error", { "allowKeywords": true } ] } } diff --git a/modules/ve-math/tools/makeSvgsAndCss.js b/modules/ve-math/tools/makeSvgsAndCss.js index e9b31ce..4397743 100755 --- a/modules/ve-math/tools/makeSvgsAndCss.js +++ b/modules/ve-math/tools/makeSvgsAndCss.js @@ -209,4 +209,4 @@ count = 0; runNext(); -} )(); +}() ); -- To view, visit https://gerrit.wikimedia.org/r/321649 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide83abeedfea27c1f4574af0069d5a9fdb81de84 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Math Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Physikerwelt <w...@physikerwelt.de> Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits