Pmiazga has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365711 )
Change subject: Hygiene: Setup and fix MinervaNeue unit tests suite
......................................................................
Hygiene: Setup and fix MinervaNeue unit tests suite
Change-Id: I13fff8eba06abad43291e481f32d9eb30c0f031b
---
M tests/phpunit/MenuBuilderTest.php
M tests/phpunit/skins/SkinMinervaPageActionsTest.php
M tests/phpunit/skins/SkinMinervaTest.php
M tests/phpunit/skins/SkinUserPageHelperTest.php
4 files changed, 10 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue
refs/changes/11/365711/1
diff --git a/tests/phpunit/MenuBuilderTest.php
b/tests/phpunit/MenuBuilderTest.php
index da6430c..07fb6b7 100644
--- a/tests/phpunit/MenuBuilderTest.php
+++ b/tests/phpunit/MenuBuilderTest.php
@@ -6,7 +6,8 @@
use MediaWiki\Minerva\MenuEntry;
/**
- * @group MobileFrontend
+ * @group MinervaNeue
+ * @group Skins
*/
class MenuTest extends \PHPUnit_Framework_TestCase {
private $homeComponent = [
diff --git a/tests/phpunit/skins/SkinMinervaPageActionsTest.php
b/tests/phpunit/skins/SkinMinervaPageActionsTest.php
index c807593..866561c 100644
--- a/tests/phpunit/skins/SkinMinervaPageActionsTest.php
+++ b/tests/phpunit/skins/SkinMinervaPageActionsTest.php
@@ -21,7 +21,8 @@
}
/**
- * @group MobileFrontend
+ * @group MinervaNeue
+ * @group Skins
*/
class SkinMinervaPageActionsTest extends MediaWikiTestCase {
diff --git a/tests/phpunit/skins/SkinMinervaTest.php
b/tests/phpunit/skins/SkinMinervaTest.php
index 9c47447..db96a02 100644
--- a/tests/phpunit/skins/SkinMinervaTest.php
+++ b/tests/phpunit/skins/SkinMinervaTest.php
@@ -33,8 +33,9 @@
}
/**
- * @coversDefaultClass SkinMinerva
- * @group MobileFrontend
+ * @coversDefaultClass SkinMinerva
+ * @group MinervaNeue
+ * @group Skins
*/
class SkinMinervaTest extends MediaWikiTestCase {
@@ -170,12 +171,7 @@
public function testGetContextSpecificModules( $fontchangerValue,
$backToTopValue,
$moduleName, $expected
) {
- $skin = TestingAccessWrapper::newFromObject(
- $this->getMockBuilder( SkinMinerva::class )
- ->disableOriginalConstructor()
- ->setMethods( [ 'getTitle' ] )
- ->getMock()
- );
+ $skin = new SkinMinerva();
$title = Title::newFromText( 'Test' );
$testContext = RequestContext::getMain();
$testContext->setTitle( $title );
diff --git a/tests/phpunit/skins/SkinUserPageHelperTest.php
b/tests/phpunit/skins/SkinUserPageHelperTest.php
index 8edd6a6..3b3f3dc 100644
--- a/tests/phpunit/skins/SkinUserPageHelperTest.php
+++ b/tests/phpunit/skins/SkinUserPageHelperTest.php
@@ -2,7 +2,8 @@
use MediaWiki\Minerva\SkinUserPageHelper;
/**
- * @group MobileFrontend
+ * @group MinervaNeue
+ * @group Skins
* @coversDefaultClass MediaWiki\Minerva\SkinUserPageHelper
*/
class SkinUserPageHelperTest extends MediaWikiTestCase {
--
To view, visit https://gerrit.wikimedia.org/r/365711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13fff8eba06abad43291e481f32d9eb30c0f031b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <pmia...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
