Pmiazga has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368816 )
Change subject: Show cursor:text for JS-only users when hovering over search
input
......................................................................
Show cursor:text for JS-only users when hovering over search input
Changes:
- introduced new <div> element visible for js-only users
* <div id="searchInput"> element is new trigger for search overlay
* when mouse is over new element "cursor:text" is applied
- search <input> is not visible only for non-js users
- introduced new styles for search module as a separate module
Bug: T161763
Change-Id: I39050a3e81c6b2e014f8955df188629a025ef2c1
---
M includes/skins/SkinMinerva.php
M includes/skins/minerva.mustache
A resources/skins.minerva.search/search.less
M skin.json
4 files changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue
refs/changes/16/368816/1
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 83af2fc..6d1976f 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -1345,6 +1345,7 @@
'skins.minerva.base.reset',
'skins.minerva.base.styles',
'skins.minerva.content.styles',
+ 'skins.minerva.search.styles',
'mediawiki.hlist',
'skins.minerva.tablet.styles',
'mediawiki.ui.icon',
diff --git a/includes/skins/minerva.mustache b/includes/skins/minerva.mustache
index e43504d..fce1459 100644
--- a/includes/skins/minerva.mustache
+++ b/includes/skins/minerva.mustache
@@ -18,9 +18,10 @@
</h1>
</div>
<div class="search-box">
- <input class="search" type="search"
name="search" id="searchInput"
+ <input class="search no-js-only"
type="search" name="search"
autocomplete="off"
placeholder="{{placeholder}}"
value="{{search}}">
+ <div class="search js-only"
tabindex="0" id="searchInput">{{placeholder}}</div>
</div>
<div>{{{searchButton}}}</div>
{{^isAnon}}<div>{{#secondaryButtonData}}{{>secondaryButton}}{{/secondaryButtonData}}</div>{{/isAnon}}
diff --git a/resources/skins.minerva.search/search.less
b/resources/skins.minerva.search/search.less
new file mode 100644
index 0000000..7ab8603
--- /dev/null
+++ b/resources/skins.minerva.search/search.less
@@ -0,0 +1,3 @@
+#searchInput {
+ cursor: text;
+}
\ No newline at end of file
diff --git a/skin.json b/skin.json
index 8f6f52f..1baa9f7 100644
--- a/skin.json
+++ b/skin.json
@@ -246,6 +246,16 @@
"resources/skins.minerva.special.styles/forms.less"
]
},
+ "skins.minerva.search.styles": {
+ "targets": [
+ "mobile",
+ "desktop"
+ ],
+ "position": "top",
+ "styles": [
+ "resources/skins.minerva.search/search.less"
+ ]
+ },
"skins.minerva.special.search.styles": {
"targets": "mobile",
"position": "top",
--
To view, visit https://gerrit.wikimedia.org/r/368816
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39050a3e81c6b2e014f8955df188629a025ef2c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <pmia...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
