Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312950
Change subject: Always render tagline container
......................................................................
Always render tagline container
I considered moving the margin-bottom from the tagline to the h1 but
for pages with a tagline the margin between the tagline and page actions
is wrong.
Rather than have to manage 2 different scenarios and introduce a "has-tagline"
or similar class it seemed neater and more consistent to always render the
tagline container.
When taglines are available everywhere this will also provide a useful signal
to bots that
scrape the html or JavaScript gadgets that a tagline for the page is needed.
Bug: T143533
Change-Id: I52576a6e744cbfb533032c7326f5f6e28631c202
---
M includes/skins/SkinMinerva.php
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/50/312950/1
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index d85f9b1..f39ddf0 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -721,7 +721,7 @@
* @returns string html for tagline
*/
protected function getTaglineHtml() {
- $tagline = false;
+ $tagline = '';
if ( $this->isUserPage ) {
$fromDate = $this->pageUser->getRegistration();
if ( is_string( $fromDate ) ) {
@@ -738,8 +738,7 @@
}
}
}
- return $tagline ?
- Html::element( 'div', [ 'class' => 'tagline' ],
$tagline ) : '';
+ return Html::element( 'div', [ 'class' => 'tagline' ], $tagline
);
}
/**
* Returns the HTML representing the heading.
--
To view, visit https://gerrit.wikimedia.org/r/312950
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52576a6e744cbfb533032c7326f5f6e28631c202
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
