Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317725
Change subject: QA: Search overlay gives false positives
......................................................................
QA: Search overlay gives false positives
Scenario "Closing search (overlay button)" will pass if the search
overlay never loads. Same goes for
"Closing search (browser button)"
To avoid this add a background check "I see the search overlay"
to ensure we've loaded it first.
Change-Id: Ib2d4883073adeb88028ac84277d691b321bafc39
---
M tests/browser/features/search.feature
1 file changed, 5 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/25/317725/1
diff --git a/tests/browser/features/search.feature
b/tests/browser/features/search.feature
index 9fc5d4d..5a1b2b8 100644
--- a/tests/browser/features/search.feature
+++ b/tests/browser/features/search.feature
@@ -5,7 +5,8 @@
Given I am using the mobile site
And the page "Selenium search test" exists
And I am on the "Main Page" page
- When I click the placeholder search box
+ And I click the placeholder search box
+ And I see the search overlay
Scenario: Closing search (overlay button)
When I click the search overlay close button
@@ -21,15 +22,13 @@
Then search results should contain "Selenium search test"
Scenario: Search with search in pages button
- And I see the search overlay
- And I type into search box "Test is used by Selenium web driver"
+ When I type into search box "Test is used by Selenium web driver"
And I see the search in pages button
And I click the search in pages button
Then I should see a list of search results
Scenario: Search with enter key
- And I see the search overlay
- And I type into search box "Test is used by Selenium web driver"
+ When I type into search box "Test is used by Selenium web driver"
And I press the enter key
Then I should see a list of search results
@@ -50,9 +49,6 @@
@login
Scenario: Clicking on a watchstar toggles the watchstar
- Given I am logged into the mobile website
- And the page "Selenium search test" exists
- When I click the placeholder search box
- And I type into search box "Selenium search tes"
+ When I type into search box "Selenium search tes"
And I click a search watch star
Then I should see a toast
--
To view, visit https://gerrit.wikimedia.org/r/317725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2d4883073adeb88028ac84277d691b321bafc39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
