Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/326192 )

Change subject: WIP: Allow hacks.less inclusion to be configurable
......................................................................

WIP: Allow hacks.less inclusion to be configurable

Add a configuration, wgMFApplyKnownTemplateHacks, to allow hacks.less to
be disabled for third parties. The default configuration is enabled.

Don't know what I'm doing yet. All will be good when I figure out how to
write the tests.

Bug: T94102
Change-Id: I6846010cfa8fe97b7b9a56d1b1dff17565f9abc7
---
M README.md
M extension.json
M includes/MobileFrontend.hooks.php
M resources/skins.minerva.content.styles/styles.less
4 files changed, 11 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/92/326192/1

diff --git a/README.md b/README.md
index 93f5359..05fef48 100644
--- a/README.md
+++ b/README.md
@@ -343,6 +343,12 @@
   ]
 ```
 
+#### $wgMFApplyKnownTemplateHacks
+
+When enabled, hacks.less is included in stylesheet.
+
+* Type: `Boolean`
+* Default: `true`
 
 #### $wgMinervaPageActions
 
diff --git a/extension.json b/extension.json
index 26aadd7..2c3484a 100644
--- a/extension.json
+++ b/extension.json
@@ -1990,6 +1990,7 @@
                "MFEnableBeta": false,
                "MFContentNamespace": 0,
                "MFDefaultSkinClass": "SkinMinerva",
+               "MFApplyKnownTemplateHacks": true,
                "MinervaPageActions": [
                        "edit",
                        "talk",
diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index b8cf5ec..2b4c1ce 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -1135,6 +1135,7 @@
                $lessVars = array_merge( $lessVars,
                        [
                                'wgMFDeviceWidthMobileSmall' => "{$config->get( 
'MFDeviceWidthMobileSmall' )}px",
+                               'wgMFApplyKnownTemplateHacks' => 
"{$config->get( 'MFApplyKnownTemplateHacks' )}",
                                'wgMFThumbnailTiny' =>  
MobilePage::TINY_IMAGE_WIDTH . 'px',
                                'wgMFThumbnailSmall' =>  
MobilePage::SMALL_IMAGE_WIDTH . 'px'
                        ]
diff --git a/resources/skins.minerva.content.styles/styles.less 
b/resources/skins.minerva.content.styles/styles.less
index 56f949c..a1b6ede 100644
--- a/resources/skins.minerva.content.styles/styles.less
+++ b/resources/skins.minerva.content.styles/styles.less
@@ -7,4 +7,6 @@
 @import 'links.less';
 @import 'text.less';
 @import 'tables.less';
-@import 'hacks.less';
+& when (@wgMFApplyKnownTemplateHacks) {
+       @import (multiple) 'hacks.less';
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/326192
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6846010cfa8fe97b7b9a56d1b1dff17565f9abc7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to