MtDu has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/332090 )

Change subject: Extend floating dialog duration to 10s
......................................................................

Extend floating dialog duration to 10s

Currently, the subscribe/unsubscribe floating dialog is shown for 5s.
This is too short to be effective, often not allowing reader to read it.
This patch extends this to 10s. This is made possible by 
https://gerrit.wikimedia.org/r/#/c/331989/2

Bug: T154763
Change-Id: Ided635f864c161e34cf849dcb55e6043c7addbd7
---
M modules/ext.newsletter.newsletters.js
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter 
refs/changes/90/332090/1

diff --git a/modules/ext.newsletter.newsletters.js 
b/modules/ext.newsletter.newsletters.js
index 3fb655c..035d4bb 100644
--- a/modules/ext.newsletter.newsletters.js
+++ b/modules/ext.newsletter.newsletters.js
@@ -76,14 +76,14 @@
                                                $subscriberCount.text( 
parseInt( $subscriberCount.text() ) - 1 );
                                                mw.notify(
                                                        mw.msg( 
'newsletter-unsubscribe-success', data.newslettersubscribe.name ),
-                                                       { autoHide: false }
+                                                       { autoHideSeconds: 10 }
                                                );
                                        } )
                                        .fail( function () {
                                                updateLinkAttribs( $link, 
'unsubscribe' );
                                                mw.notify(
                                                        mw.msg( 
'newsletter-unsubscribe-error' ),
-                                                       { type: 'error', 
autoHide: false }
+                                                       { type: 'error', 
autoHideSeconds: 10 }
                                                );
                                        } );
                        } else {
@@ -95,14 +95,14 @@
                                                $subscriberCount.text( 
parseInt( $subscriberCount.text() ) + 1 );
                                                mw.notify(
                                                        mw.msg( 
'newsletter-subscribe-success', data.newslettersubscribe.name ),
-                                                       { autoHide: false }
+                                                       { autoHideSeconds: 10 }
                                                );
                                        } )
                                        .fail( function () {
                                                updateLinkAttribs( $link, 
'subscribe' );
                                                mw.notify(
                                                        mw.msg( 
'newsletter-subscribe-error' ),
-                                                       { type: 'error', 
autoHide: false }
+                                                       { type: 'error', 
autoHideSeconds: 10 }
                                                );
                                        } );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/332090
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ided635f864c161e34cf849dcb55e6043c7addbd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: MtDu <justin.d...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to