Zoranzoki21 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403306 )
Change subject: Score: Replace "getSelectedItem" with "findSelectedItem"
......................................................................
Score: Replace "getSelectedItem" with "findSelectedItem"
Replace instances of getSelectedItem with findSelectedItem in
modules/ve-score/ve.ui.MWScoreInspector.js in MediaWiki's Score extension.
Bug: T184041
Change-Id: I85766266b4325296119f358a9fb8d136532a3c4c
---
M modules/ve-score/ve.ui.MWScoreInspector.js
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Score
refs/changes/06/403306/1
diff --git a/modules/ve-score/ve.ui.MWScoreInspector.js
b/modules/ve-score/ve.ui.MWScoreInspector.js
index ba6ccce..3de0296 100644
--- a/modules/ve-score/ve.ui.MWScoreInspector.js
+++ b/modules/ve-score/ve.ui.MWScoreInspector.js
@@ -245,8 +245,8 @@
ve.ui.MWScoreInspector.super.prototype.updateMwData.call( this, mwData
);
// Get data from inspector
- lang = this.langSelect.getSelectedItem().getData();
- noteLanguage =
this.noteLanguageDropdown.getMenu().getSelectedItem().getData();
+ lang = this.langSelect.findSelectedItem().getData();
+ noteLanguage =
this.noteLanguageDropdown.getMenu().findSelectedItem().getData();
raw = !this.rawCheckbox.isDisabled() && this.rawCheckbox.isSelected();
// audioCheckbox is selected if an audio file is being included,
whether that file
// is being auto-generated or whether an existing file is being used;
but the "vorbis"
@@ -272,7 +272,7 @@
*/
ve.ui.MWScoreInspector.prototype.toggleDisableRawCheckbox = function () {
// Disable the checkbox if the language is not LilyPond
- this.rawCheckbox.setDisabled(
this.langSelect.getSelectedItem().getData() !== 'lilypond' );
+ this.rawCheckbox.setDisabled(
this.langSelect.findSelectedItem().getData() !== 'lilypond' );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/403306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85766266b4325296119f358a9fb8d136532a3c4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: master
Gerrit-Owner: Zoranzoki21 <zorandori4...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
