jenkins-bot has submitted this change and it was merged.
Change subject: Fix SecurePoll_VoterEligibilityPage::saveList visibility
......................................................................
Fix SecurePoll_VoterEligibilityPage::saveList visibility
SecurePoll_VoterEligibilityPage::saveList can now be private
as we don't support PHP 5.3 anymore.
This reverts commit 27e620df25d881ca9e5413eb6101e0f451e1bf20.
Bug: T135768
Change-Id: Ib9517fe2255fb8546934ab7fbf120cff32ac0bd2
---
M includes/pages/VoterEligibilityPage.php
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
jenkins-bot: Verified
Huji: Looks good to me, approved
diff --git a/includes/pages/VoterEligibilityPage.php
b/includes/pages/VoterEligibilityPage.php
index 1754f70..f9e7bd6 100644
--- a/includes/pages/VoterEligibilityPage.php
+++ b/includes/pages/VoterEligibilityPage.php
@@ -200,11 +200,7 @@
return $names;
}
- /**
- * @todo Make this really private when we don't support PHP 5.3 anymore
- * @private
- */
- public function saveList( $property, $names, $comment ) {
+ private function saveList( $property, $names, $comment ) {
global $wgSecurePollUseNamespace;
$wikis = $this->election->getProperty( 'wikis' );
--
To view, visit https://gerrit.wikimedia.org/r/289737
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9517fe2255fb8546934ab7fbf120cff32ac0bd2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SecurePoll
Gerrit-Branch: master
Gerrit-Owner: Dereckson <dereck...@espace-win.org>
Gerrit-Reviewer: Huji <huji.h...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
