TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316938
Change subject: Untested: Encode namespace when generating info link
......................................................................
Untested: Encode namespace when generating info link
Bug: T138770
Change-Id: I0c0e5fce0c482050126efe40b3d329bdffd900f5
---
M TimedMediaHandler.hooks.php
M resources/mw-info-button/mw-info-button.js
2 files changed, 3 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/38/316938/1
diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index 5123520..90f980f 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -155,6 +155,7 @@
'targets' => [ 'mobile', 'desktop' ],
'dependencies' => [
'ext.tmh.video-js',
+ 'mediawiki.Title',
],
],
'ext.tmh.player' => $baseExtensionResource + [
diff --git a/resources/mw-info-button/mw-info-button.js
b/resources/mw-info-button/mw-info-button.js
index cb0f081..59ca57f 100644
--- a/resources/mw-info-button/mw-info-button.js
+++ b/resources/mw-info-button/mw-info-button.js
@@ -36,10 +36,8 @@
var player = this;
player.ready(function(){
- var link = mw.config.get('wgScript') + '?title='
- + mw.config.get( 'wgFormattedNamespaces' )['6'] + ':'
- + encodeURIComponent( player.el().getAttribute( 'data-mwtitle' ) );
- var button = new InfoButton( Button, link );
+ var title = mw.Title.makeTitle( mw.config.get( 'wgNamespaceIds'
).file, player.el().getAttribute( 'data-mwtitle' ) );
+ var button = new InfoButton( Button, title.getUrl() );
player.controlBar.infoButton = player.controlBar.addChild(button);
});
};
--
To view, visit https://gerrit.wikimedia.org/r/316938
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c0e5fce0c482050126efe40b3d329bdffd900f5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
