Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404660 )

Change subject: Make visual diffs the default in visual mode
......................................................................

Make visual diffs the default in visual mode

Bug: T178248
Change-Id: I9fe22862d4415df034a0054f934c9ebd1d731a5d
---
M modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/60/404660/1

diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index 96829ac..ab247e9 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -749,9 +749,8 @@
                        // Config values used here:
                        // * visualeditor-diffmode-visual
                        // * visualeditor-diffmode-source
-                       // TODO: Make 'visual' the default for visual mode 
(T178248)
                        this.reviewModeButtonSelect.selectItemByData(
-                               ve.userConfig( 'visualeditor-diffmode-' + 
surfaceMode ) || 'source'
+                               ve.userConfig( 'visualeditor-diffmode-' + 
surfaceMode ) || surfaceMode
                        );
 
                        // Old messages should not persist

-- 
To view, visit https://gerrit.wikimedia.org/r/404660
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fe22862d4415df034a0054f934c9ebd1d731a5d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to