[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Don't use $wgUser in EntityContentFactoryTest::testGetPermis...

[Ladsgroup (Code Review)]

Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/332718 )

Change subject: Don't use $wgUser in 
EntityContentFactoryTest::testGetPermissionStatusForEntity
......................................................................

Don't use $wgUser in EntityContentFactoryTest::testGetPermissionStatusForEntity

Bug: T155600
Change-Id: I0bb012e8da87d299fe406068c82422b4bc661939
---
M repo/tests/phpunit/includes/Content/EntityContentFactoryTest.php
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/18/332718/1

diff --git a/repo/tests/phpunit/includes/Content/EntityContentFactoryTest.php 
b/repo/tests/phpunit/includes/Content/EntityContentFactoryTest.php
index 7f80661..3eaf6c5 100644
--- a/repo/tests/phpunit/includes/Content/EntityContentFactoryTest.php
+++ b/repo/tests/phpunit/includes/Content/EntityContentFactoryTest.php
@@ -5,6 +5,7 @@
 use InvalidArgumentException;
 use OutOfBoundsException;
 use Title;
+use User;
 use Wikibase\DataModel\Entity\EntityDocument;
 use Wikibase\DataModel\Entity\EntityRedirect;
 use Wikibase\DataModel\Entity\Item;
@@ -274,9 +275,9 @@
         * @dataProvider provideGetPermissionStatusForEntity
         */
        public function testGetPermissionStatusForEntity( $action, array 
$permissions, $id, array $expectations ) {
-               global $wgUser;
 
                $entity = new Item();
+               $user = new User('Foo');
 
                if ( $id ) {
                        // "exists"
@@ -298,17 +299,17 @@
                $factory = $this->newFactory();
 
                if ( isset( $expectations['getPermissionStatusForEntity'] ) ) {
-                       $status = $factory->getPermissionStatusForEntity( 
$wgUser, $action, $entity );
+                       $status = $factory->getPermissionStatusForEntity( 
$user, $action, $entity );
                        $this->assertEquals( 
$expectations['getPermissionStatusForEntity'], $status->isOK() );
                }
 
                if ( isset( $expectations['getPermissionStatusForEntityType'] ) 
) {
-                       $status = $factory->getPermissionStatusForEntityType( 
$wgUser, $action, $entity->getType() );
+                       $status = $factory->getPermissionStatusForEntityType( 
$user, $action, $entity->getType() );
                        $this->assertEquals( 
$expectations['getPermissionStatusForEntityType'], $status->isOK() );
                }
 
                if ( isset( $expectations['getPermissionStatusForEntityId'] ) ) 
{
-                       $status = $factory->getPermissionStatusForEntityId( 
$wgUser, $action, $entity->getId() );
+                       $status = $factory->getPermissionStatusForEntityId( 
$user, $action, $entity->getId() );
                        $this->assertEquals( 
$expectations['getPermissionStatusForEntityId'], $status->isOK() );
                }
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/332718
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bb012e8da87d299fe406068c82422b4bc661939
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <ladsgr...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits