jenkins-bot has submitted this change and it was merged.
Change subject: Enable caching per default for the AvailableBadges Api module
......................................................................
Enable caching per default for the AvailableBadges Api module
The values should hardly ever change, thus it should be
safe to cache them for an hour.
This could also be done for FormatSnakValue/ParseValue when
the results don't include any entity labels. We could cache
results depending on the data type there, but I'm not sure
it's worth it.
Change-Id: I722969076fbae6a0c0969b89358d4e2ee53e940f
---
M repo/includes/Api/AvailableBadges.php
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Anomie: Looks good to me, but someone else must approve
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/Api/AvailableBadges.php
b/repo/includes/Api/AvailableBadges.php
index 26755cd..76db440 100644
--- a/repo/includes/Api/AvailableBadges.php
+++ b/repo/includes/Api/AvailableBadges.php
@@ -23,6 +23,7 @@
*/
public function execute() {
$this->getMain()->setCacheMode( 'public' );
+ $this->getMain()->setCacheMaxAge( 3600 );
$badgeItems =
WikibaseRepo::getDefaultInstance()->getSettings()->getSetting( 'badgeItems' );
$idStrings = array_keys( $badgeItems );
--
To view, visit https://gerrit.wikimedia.org/r/307732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I722969076fbae6a0c0969b89358d4e2ee53e940f
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
