Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391358 )
Change subject: Media: stop filtering by size + mime type
......................................................................
Media: stop filtering by size + mime type
We'll be going in the direction of leaving these in but marking them up
with the necessary info for clients to decide if and how to use them.
Bug: T177430
Change-Id: Ie79c2b9b422ecd3607808f103b2821a211093a84
---
M lib/media.js
1 file changed, 3 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps
refs/changes/58/391358/1
diff --git a/lib/media.js b/lib/media.js
index 506be2a..049bace 100644
--- a/lib/media.js
+++ b/lib/media.js
@@ -5,7 +5,6 @@
const Title = require('mediawiki-title').Title;
const MAX_ITEM_COUNT = 500;
-const MIN_IMAGE_SIZE = 64;
const MAX_IMAGE_WIDTH = 1280;
@@ -59,18 +58,11 @@
});
}
-function filterTitles(items) {
+function getTitles(items) {
// Reject gallery items if they're too small.
// Also reject SVG and PNG items by default, because they're likely to be
// logos and/or presentational images.
- return items.filter((item) => {
- const imageInfo = item.imageinfo && Array.isArray(item.imageinfo) &&
item.imageinfo[0];
- return imageInfo
- && imageInfo.width >= MIN_IMAGE_SIZE
- && imageInfo.height >= MIN_IMAGE_SIZE
- && !imageInfo.mime.includes('svg')
- && !imageInfo.mime.includes('png');
- }).map((item) => {
+ return items.map((item) => {
return item.title;
});
}
@@ -103,7 +95,7 @@
prop: 'videoinfo',
viprop: 'url|dimensions|mime|extmetadata|derivatives',
viurlwidth: MAX_IMAGE_WIDTH,
- titles: filterTitles(response.body.query.pages).join('|'),
+ titles: getTitles(response.body.query.pages).join('|'),
continue: ''
};
return api.mwApiGet(app, req.params.domain, query).then((response) => {
--
To view, visit https://gerrit.wikimedia.org/r/391358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie79c2b9b422ecd3607808f103b2821a211093a84
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
