Subramanya Sastry has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327038 )

Change subject: T152727: Fix bug in self-closing tag lint tracking
......................................................................

T152727: Fix bug in self-closing tag lint tracking

Change-Id: I2831d6f23e221bce1f81b898b57f2055e4d926dc
---
M lib/wt2html/pp/handlers/linter.js
M tests/mocha/lintertest.js
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/38/327038/1

diff --git a/lib/wt2html/pp/handlers/linter.js 
b/lib/wt2html/pp/handlers/linter.js
index e5cf66d..9d3ac5b 100644
--- a/lib/wt2html/pp/handlers/linter.js
+++ b/lib/wt2html/pp/handlers/linter.js
@@ -91,7 +91,7 @@
                DU.hasLiteralHTMLMarker(dp) &&
                dsr)) {
 
-               if (dp.selfClose) {
+               if (dp.selfClose && cNodeName !== 'meta') {
                        lintObj = {
                                src: env.page.src,
                                dsr: dsr,
diff --git a/tests/mocha/lintertest.js b/tests/mocha/lintertest.js
index 05871ff..82aa193 100644
--- a/tests/mocha/lintertest.js
+++ b/tests/mocha/lintertest.js
@@ -170,7 +170,7 @@
                        });
                });
                it('should lint self-closing tags corrrectly', function() {
-                       return parseWT('foo<b />bar<span />baz<hr />boo<br 
/>').then(function(result) {
+                       return parseWT('foo<b />bar<span />baz<hr />boo<br /> 
<ref name="boo" />').then(function(result) {
                                result.should.have.length(2);
                                result[0].should.have.a.property("type", 
"self-closed-tag");
                                result[0].dsr.should.include.members([ 3, 8, 5, 
0 ]);

-- 
To view, visit https://gerrit.wikimedia.org/r/327038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2831d6f23e221bce1f81b898b57f2055e4d926dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to