Arlolra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386319 )

Change subject: T176728: Deleting nodes is slow ...
......................................................................

T176728: Deleting nodes is slow ...

 * This shaves a minute off the slow skwiki posts Google is sending us.

 * Should probably wait for the linked list domino implementation which
   makes deleting cheap, since this patch is incomplete.

Change-Id: I990d2ae947e4d833acefe981478f9c8e1f68f506
---
M lib/wt2html/pp/processors/wrapTemplates.js
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/19/386319/1

diff --git a/lib/wt2html/pp/processors/wrapTemplates.js 
b/lib/wt2html/pp/processors/wrapTemplates.js
index 15eb165..bab1a6d 100644
--- a/lib/wt2html/pp/processors/wrapTemplates.js
+++ b/lib/wt2html/pp/processors/wrapTemplates.js
@@ -878,10 +878,12 @@
                // it is guaranteed to be a marker meta added to mark the start
                // of the template.
                if (DU.isTplMarkerMeta(startElem)) {
-                       DU.deleteNode(startElem);
+                       var t1 = startElem.ownerDocument.createTextNode('');
+                       startElem.parentNode.replaceChild(t1, startElem);
                }
 
-               DU.deleteNode(range.endElem);
+               var t2 = range.endElem.ownerDocument.createTextNode('');
+               range.endElem.parentNode.replaceChild(t2, range.endElem);
        }
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/386319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I990d2ae947e4d833acefe981478f9c8e1f68f506
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <abrea...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to