jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.ForeignStructuredUpload: Always use '|1=' for
description templates
......................................................................
mediawiki.ForeignStructuredUpload: Always use '|1=' for description templates
'|1=' should be always used, following the standard on Commons.
Follow-up to 56af60ab91e0b74af9e416b11fa487e15097f5bc.
Bug: T119691
Change-Id: Ied787ecb91aaae3f643c9d013b8982ddabea8142
---
M resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, but someone else must approve
TTO: Looks good to me, but someone else must approve
Florianschmidtwelzow: Looks good to me, approved
Steinsplitter: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
b/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
index 5e79039..0117cea 100644
--- a/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
+++ b/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
@@ -136,12 +136,11 @@
* @return {string}
*/
ForeignStructuredUpload.prototype.getDescriptions = function () {
- var i, desc, hasEquals, templateCalls = [];
+ var i, desc, templateCalls = [];
for ( i = 0; i < this.descriptions.length; i++ ) {
desc = this.descriptions[ i ];
- hasEquals = desc.text.indexOf( '=' ) !== -1;
- templateCalls.push( '{{' + desc.language + ( hasEquals
? '|1=' : '|' ) + desc.text + '}}' );
+ templateCalls.push( '{{' + desc.language + '|1=' +
desc.text + '}}' );
}
return templateCalls.join( '\n' );
--
To view, visit https://gerrit.wikimedia.org/r/257174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied787ecb91aaae3f643c9d013b8982ddabea8142
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zhuyifei1999 <zhuyifei1...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Edokter <er...@darcoury.nl>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Steinsplitter <steinsplit...@wikipedia.de>
Gerrit-Reviewer: TTO <at.li...@live.com.au>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
