Filippo Giunchedi has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174691

Change subject: merge job timing stats together
......................................................................

merge job timing stats together

having per-status job timings yields too many metrics, particularly because
statsd will emit derived metrics for timings (percentiles, min/max, etc)

Change-Id: I7cfc876e134d51fbc6f969bfec5b87f21cb26517
---
M zuul/scheduler.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul 
refs/changes/91/174691/1

diff --git a/zuul/scheduler.py b/zuul/scheduler.py
index 2cd4d46..08c11bd 100644
--- a/zuul/scheduler.py
+++ b/zuul/scheduler.py
@@ -502,12 +502,12 @@
         try:
             if statsd and build.pipeline:
                 jobname = build.job.name.replace('.', '_')
-                key = 'zuul.pipeline.%s.job.%s.%s' % (build.pipeline.name,
-                                                      jobname, build.result)
+                key = 'zuul.pipeline.%s.job.%s' % (build.pipeline.name,
+                                                   jobname)
                 if build.result in ['SUCCESS', 'FAILURE'] and build.start_time:
                     dt = int((build.end_time - build.start_time) * 1000)
                     statsd.timing(key, dt)
-                statsd.incr(key)
+                statsd.incr(key + '.' + build.result)
                 key = 'zuul.pipeline.%s.all_jobs' % build.pipeline.name
                 statsd.incr(key)
         except:

-- 
To view, visit https://gerrit.wikimedia.org/r/174691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cfc876e134d51fbc6f969bfec5b87f21cb26517
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul
Gerrit-Branch: master
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to