Faidon Liambotis has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364341 )
Change subject: ipmi: add a 5 second timeout to the ipmi_lan fact
......................................................................
ipmi: add a 5 second timeout to the ipmi_lan fact
On some systems, like sodium, that have a broken BMC that needs a reset,
bmc-config takes up to 10 minutes to respond. Add a timeout to the fact
of 5 seconds to avoid delaying the puppet runs for that long.
Change-Id: I0a0142cd1a8beb519f73539e052058343b0ee3b9
---
M modules/ipmi/lib/facter/ipmi.rb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Faidon Liambotis: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ipmi/lib/facter/ipmi.rb b/modules/ipmi/lib/facter/ipmi.rb
index 9c64c6b..c932071 100644
--- a/modules/ipmi/lib/facter/ipmi.rb
+++ b/modules/ipmi/lib/facter/ipmi.rb
@@ -14,7 +14,7 @@
end
end
-Facter.add(:ipmi_lan) do
+Facter.add(:ipmi_lan, :timeout => 5) do
confine :has_ipmi => true
confine do
File.exists?('/usr/sbin/bmc-config') || File.exists?('/usr/bin/ipmitool')
--
To view, visit https://gerrit.wikimedia.org/r/364341
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a0142cd1a8beb519f73539e052058343b0ee3b9
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
